diff mbox series

[2/3] bytcr-rt5651: Fix high noise level + soft input on DMIC

Message ID 20200608202142.92894-2-hdegoede@redhat.com (mailing list archive)
State New, archived
Headers show
Series [1/3] bytcr-rt5640: Fix DMIC1 not working when connected over AIF2 | expand

Commit Message

Hans de Goede June 8, 2020, 8:21 p.m. UTC
The DMIC needs to have the DMIC ASRC enabled, otherwise capturing audio
from it results in mostly capturing noise + the actual recorded voice
very soft in the background of the noise.

This has been tested on a Point of View P1006W v1.0 tablet, which is the
only RT5651 X86 device using a DMIC that I am aware of.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 ucm2/codecs/rt5651/DigitalMic.conf | 2 ++
 1 file changed, 2 insertions(+)

Comments

Jaroslav Kysela June 9, 2020, 8:50 a.m. UTC | #1
Dne 08. 06. 20 v 22:21 Hans de Goede napsal(a):
> The DMIC needs to have the DMIC ASRC enabled, otherwise capturing audio
> from it results in mostly capturing noise + the actual recorded voice
> very soft in the background of the noise.
> 
> This has been tested on a Point of View P1006W v1.0 tablet, which is the
> only RT5651 X86 device using a DMIC that I am aware of.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>   ucm2/codecs/rt5651/DigitalMic.conf | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/ucm2/codecs/rt5651/DigitalMic.conf b/ucm2/codecs/rt5651/DigitalMic.conf
> index aa40c1c..d21b21d 100644
> --- a/ucm2/codecs/rt5651/DigitalMic.conf
> +++ b/ucm2/codecs/rt5651/DigitalMic.conf
> @@ -4,12 +4,14 @@ SectionDevice."Mic" {
>   	EnableSequence [
>   		cset "name='Stereo1 ADC MIXL ADC2 Switch' on"
>   		cset "name='Stereo1 ADC MIXR ADC2 Switch' on"
> +		cset "name='DMIC ASRC Switch' on"
>   		cset "name='Internal Mic Switch' on"
>   	]
>   
>   	DisableSequence [
>   		cset "name='Stereo1 ADC MIXL ADC2 Switch' off"
>   		cset "name='Stereo1 ADC MIXR ADC2 Switch' off"
> +		cset "name='DMIC ASRC Switch' off"
>   		cset "name='Internal Mic Switch' off"
>   	]
>   
> 

Applied to the alsa-ucm-conf repo. Thank you.

						Jaroslav
diff mbox series

Patch

diff --git a/ucm2/codecs/rt5651/DigitalMic.conf b/ucm2/codecs/rt5651/DigitalMic.conf
index aa40c1c..d21b21d 100644
--- a/ucm2/codecs/rt5651/DigitalMic.conf
+++ b/ucm2/codecs/rt5651/DigitalMic.conf
@@ -4,12 +4,14 @@  SectionDevice."Mic" {
 	EnableSequence [
 		cset "name='Stereo1 ADC MIXL ADC2 Switch' on"
 		cset "name='Stereo1 ADC MIXR ADC2 Switch' on"
+		cset "name='DMIC ASRC Switch' on"
 		cset "name='Internal Mic Switch' on"
 	]
 
 	DisableSequence [
 		cset "name='Stereo1 ADC MIXL ADC2 Switch' off"
 		cset "name='Stereo1 ADC MIXR ADC2 Switch' off"
+		cset "name='DMIC ASRC Switch' off"
 		cset "name='Internal Mic Switch' off"
 	]