From patchwork Mon Jun 8 20:21:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 11593953 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C70B490 for ; Mon, 8 Jun 2020 20:22:57 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5BD5E20760 for ; Mon, 8 Jun 2020 20:22:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="nkzyh0xA"; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="C1Eb4h9Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BD5E20760 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E765B4E; Mon, 8 Jun 2020 22:22:07 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E765B4E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1591647776; bh=q3WAxFXYkLFQwiYhY+Y0zJEJbIJj5BWJWRTBLZyv1xE=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=nkzyh0xAal469row4Xuot9j4QHoNAxM/xu0EaF9no4uf7rsmrOu9dFISlnajRkBy/ 57WnDB0ogOYf00T8we2rnILAyKC2fsS83dzTnJcVcrU0RNiviRQ264Y0GXstGDUkhl Thx/0v+EgOoXH0EJlpbYviZdKqNDbfkX5jGnbKpI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id E64C6F801F7; Mon, 8 Jun 2020 22:22:01 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0A223F8021E; Mon, 8 Jun 2020 22:22:00 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on alsa1.perex.cz X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_NONE autolearn=disabled version=3.4.0 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 43742F80124 for ; Mon, 8 Jun 2020 22:21:54 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 43742F80124 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="C1Eb4h9Z" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591647713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PxQFYhQlenCf2Gvq4gPwtQYTqKj9U0Rn8vNZE8pcjHs=; b=C1Eb4h9ZXoaZt2YShMpXNHw3tIv4IUdfMnwROaENiAPJg0ryECOaCGJeut5fZZd1PvO3Ym qo0qwHyih1OANRwGxRujy9BDdneSWifqgkjLgn+ImpZbwxS26qdOt5qKHkiu5tCUg7kWHl bQbtXWuunrMjAfSxF5Hzef8IzG7vSkQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-298-bwtsGpopOui5H03F0gU6Mw-1; Mon, 08 Jun 2020 16:21:51 -0400 X-MC-Unique: bwtsGpopOui5H03F0gU6Mw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B950119057BA; Mon, 8 Jun 2020 20:21:47 +0000 (UTC) Received: from x1.localdomain.com (ovpn-114-122.ams2.redhat.com [10.36.114.122]) by smtp.corp.redhat.com (Postfix) with ESMTP id 963796116D; Mon, 8 Jun 2020 20:21:46 +0000 (UTC) From: Hans de Goede To: Jaroslav Kysela Subject: [PATCH 2/3] bytcr-rt5651: Fix high noise level + soft input on DMIC Date: Mon, 8 Jun 2020 22:21:41 +0200 Message-Id: <20200608202142.92894-2-hdegoede@redhat.com> In-Reply-To: <20200608202142.92894-1-hdegoede@redhat.com> References: <20200608202142.92894-1-hdegoede@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Cc: Hans de Goede , alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" The DMIC needs to have the DMIC ASRC enabled, otherwise capturing audio from it results in mostly capturing noise + the actual recorded voice very soft in the background of the noise. This has been tested on a Point of View P1006W v1.0 tablet, which is the only RT5651 X86 device using a DMIC that I am aware of. Signed-off-by: Hans de Goede --- ucm2/codecs/rt5651/DigitalMic.conf | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ucm2/codecs/rt5651/DigitalMic.conf b/ucm2/codecs/rt5651/DigitalMic.conf index aa40c1c..d21b21d 100644 --- a/ucm2/codecs/rt5651/DigitalMic.conf +++ b/ucm2/codecs/rt5651/DigitalMic.conf @@ -4,12 +4,14 @@ SectionDevice."Mic" { EnableSequence [ cset "name='Stereo1 ADC MIXL ADC2 Switch' on" cset "name='Stereo1 ADC MIXR ADC2 Switch' on" + cset "name='DMIC ASRC Switch' on" cset "name='Internal Mic Switch' on" ] DisableSequence [ cset "name='Stereo1 ADC MIXL ADC2 Switch' off" cset "name='Stereo1 ADC MIXR ADC2 Switch' off" + cset "name='DMIC ASRC Switch' off" cset "name='Internal Mic Switch' off" ]