| Message ID | 20200619031407.116140-1-john.stultz@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3bd057c8219d4006f2b436cea2ae5ac723067a51 |
| Headers | show |
| Series | [v3] ASoC: qcom: Kconfig: Tweak dependencies on SND_SOC_SDM845 | expand |
On 19/06/2020 04:14, John Stultz wrote: > CROS_EC isn't strictly required for audio to work > on other SDM845 platforms (like the Dragonboard 845c). > > So lets remove the dependency and select the related > CROS_EC options via imply. > > Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > Cc: Rohit kumar <rohitkr@codeaurora.org> > Cc: Patrick Lai <plai@codeaurora.org> > Cc: Banajit Goswami <bgoswami@codeaurora.org> > Cc: Liam Girdwood <lgirdwood@gmail.com> > Cc: Mark Brown <broonie@kernel.org> > Cc: Jaroslav Kysela <perex@perex.cz> > Cc: Takashi Iwai <tiwai@suse.com> > Cc: alsa-devel@alsa-project.org > Signed-off-by: John Stultz <john.stultz@linaro.org> > --- Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > v2: Switch to using imply as suggested by Srinivas > --- > sound/soc/qcom/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig > index f51b28d1b94d..0ea4cde9f4f0 100644 > --- a/sound/soc/qcom/Kconfig > +++ b/sound/soc/qcom/Kconfig > @@ -99,12 +99,12 @@ config SND_SOC_MSM8996 > > config SND_SOC_SDM845 > tristate "SoC Machine driver for SDM845 boards" > - depends on QCOM_APR && CROS_EC && I2C && SOUNDWIRE > + depends on QCOM_APR && I2C && SOUNDWIRE > select SND_SOC_QDSP6 > select SND_SOC_QCOM_COMMON > select SND_SOC_RT5663 > select SND_SOC_MAX98927 > - select SND_SOC_CROS_EC_CODEC > + imply SND_SOC_CROS_EC_CODEC > help > To add support for audio on Qualcomm Technologies Inc. > SDM845 SoC-based systems. >
On Fri, 19 Jun 2020 03:14:07 +0000, John Stultz wrote: > CROS_EC isn't strictly required for audio to work > on other SDM845 platforms (like the Dragonboard 845c). > > So lets remove the dependency and select the related > CROS_EC options via imply. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: qcom: Kconfig: Tweak dependencies on SND_SOC_SDM845 commit: 3bd057c8219d4006f2b436cea2ae5ac723067a51 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig index f51b28d1b94d..0ea4cde9f4f0 100644 --- a/sound/soc/qcom/Kconfig +++ b/sound/soc/qcom/Kconfig @@ -99,12 +99,12 @@ config SND_SOC_MSM8996 config SND_SOC_SDM845 tristate "SoC Machine driver for SDM845 boards" - depends on QCOM_APR && CROS_EC && I2C && SOUNDWIRE + depends on QCOM_APR && I2C && SOUNDWIRE select SND_SOC_QDSP6 select SND_SOC_QCOM_COMMON select SND_SOC_RT5663 select SND_SOC_MAX98927 - select SND_SOC_CROS_EC_CODEC + imply SND_SOC_CROS_EC_CODEC help To add support for audio on Qualcomm Technologies Inc. SDM845 SoC-based systems.
CROS_EC isn't strictly required for audio to work on other SDM845 platforms (like the Dragonboard 845c). So lets remove the dependency and select the related CROS_EC options via imply. Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Cc: Rohit kumar <rohitkr@codeaurora.org> Cc: Patrick Lai <plai@codeaurora.org> Cc: Banajit Goswami <bgoswami@codeaurora.org> Cc: Liam Girdwood <lgirdwood@gmail.com> Cc: Mark Brown <broonie@kernel.org> Cc: Jaroslav Kysela <perex@perex.cz> Cc: Takashi Iwai <tiwai@suse.com> Cc: alsa-devel@alsa-project.org Signed-off-by: John Stultz <john.stultz@linaro.org> --- v2: Switch to using imply as suggested by Srinivas --- sound/soc/qcom/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)