| Message ID | 20200724085644.9837-1-steves.lee@maximintegrated.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 62f2c7797de376e39bca5630a0f80209ffb4c70f |
| Headers | show |
| Series | None | expand |
On Fri, Jul 24, 2020 at 05:56:44PM +0900, Steve Lee wrote: > MAX98390_DSM_PARAM_MAX_SIZE is changed to support extended > register update. I'm missing patches 1-2 and have no cover letter - what's the story with dependencies?
> -----Original Message----- > From: Mark Brown <broonie@kernel.org> > Sent: Friday, July 24, 2020 7:51 PM > To: Steve Lee <SteveS.Lee@maximintegrated.com> > Cc: lgirdwood@gmail.com; perex@perex.cz; tiwai@suse.com; > ckeepax@opensource.cirrus.com; geert@linux-m68k.org; > rf@opensource.wolfsonmicro.com; shumingf@realtek.com; > srinivas.kandagatla@linaro.org; krzk@kernel.org; dmurphy@ti.com; > jack.yu@realtek.com; nuno.sa@analog.com; linux-kernel@vger.kernel.org; > alsa-devel@alsa-project.org; ryan.lee.maxim@gmail.com; Ryan Lee > <RyanS.Lee@maximintegrated.com>; steves.lee.maxim@gmail.com > Subject: Re: [PATCH 3/3] ASoC: max98390: update dsm param bin max size > > On Fri, Jul 24, 2020 at 05:56:44PM +0900, Steve Lee wrote: > > MAX98390_DSM_PARAM_MAX_SIZE is changed to support extended register > > update. > > I'm missing patches 1-2 and have no cover letter - what's the story with > dependencies? I will re-send patch ang please ignore this patch. DSM init param is extended to cover more register so that DSM MAX PARAM SIZE value is changed. Thanks.!
On Mon, Jul 27, 2020 at 02:00:09AM +0000, Steve Lee wrote: > > I'm missing patches 1-2 and have no cover letter - what's the story with > > dependencies? > I will re-send patch ang please ignore this patch. > DSM init param is extended to cover more register so that DSM MAX PARAM SIZE value is changed. I applied these on Friday having found the other two patches (you're not sending things as a thread so they get lost, for example if someone sends a big series at a similar time like what happened on Friday) so your new version won't apply, please resend whatever change you want to make as an incremental patch against current code. Please do not submit new versions of already applied patches, please submit incremental updates to the existing code. Modifying existing commits creates problems for other users building on top of those commits so it's best practice to only change pubished git commits if absolutely essential.
> -----Original Message----- > From: Mark Brown <broonie@kernel.org> > Sent: Monday, July 27, 2020 10:08 PM > To: Steve Lee <SteveS.Lee@maximintegrated.com> > Cc: lgirdwood@gmail.com; perex@perex.cz; tiwai@suse.com; > ckeepax@opensource.cirrus.com; geert@linux-m68k.org; > rf@opensource.wolfsonmicro.com; shumingf@realtek.com; > srinivas.kandagatla@linaro.org; krzk@kernel.org; dmurphy@ti.com; > jack.yu@realtek.com; nuno.sa@analog.com; linux-kernel@vger.kernel.org; > alsa-devel@alsa-project.org; ryan.lee.maxim@gmail.com; Ryan Lee > <RyanS.Lee@maximintegrated.com>; steves.lee.maxim@gmail.com > Subject: Re: [PATCH 3/3] ASoC: max98390: update dsm param bin max size > > On Mon, Jul 27, 2020 at 02:00:09AM +0000, Steve Lee wrote: > > > > I'm missing patches 1-2 and have no cover letter - what's the story > > > with dependencies? > > > I will re-send patch ang please ignore this patch. > > DSM init param is extended to cover more register so that DSM MAX PARAM > SIZE value is changed. > > I applied these on Friday having found the other two patches (you're not sending > things as a thread so they get lost, for example if someone sends a big series at > a similar time like what happened on Friday) so your new version won't apply, > please resend whatever change you want to make as an incremental patch > against current code. > > Please do not submit new versions of already applied patches, please submit > incremental updates to the existing code. Modifying existing commits creates > problems for other users building on top of those commits so it's best practice > to only change pubished git commits if absolutely essential. Thanks, I missed patched was already applied. I will send patch upon these patches later.
diff --git a/sound/soc/codecs/max98390.h b/sound/soc/codecs/max98390.h index 5f444e7779b0..dff884f68e3e 100644 --- a/sound/soc/codecs/max98390.h +++ b/sound/soc/codecs/max98390.h @@ -650,7 +650,7 @@ /* DSM register offset */ #define MAX98390_DSM_PAYLOAD_OFFSET 16 -#define MAX98390_DSM_PARAM_MAX_SIZE 770 +#define MAX98390_DSM_PARAM_MAX_SIZE 1024 #define MAX98390_DSM_PARAM_MIN_SIZE 670 struct max98390_priv {
MAX98390_DSM_PARAM_MAX_SIZE is changed to support extended register update. Signed-off-by: Steve Lee <steves.lee@maximintegrated.com> --- sound/soc/codecs/max98390.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)