| Message ID | 20200830112633.6732-1-krzk@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3e7ba1c0432ef9a792b9c77d36f78037626303b0 |
| Headers | show |
| Series | [1/2] dt-bindings: sound: midas-audio: Correct parsing sound-dai phandles | expand |
On 30.08.2020 13:26, Krzysztof Kozlowski wrote: > The "sound-dai" property has cells therefore phandle-array should be > used, even if it is just one phandle. This fixes dtbs_check warnings > like: > > arch/arm/boot/dts/exynos4412-trats2.dt.yaml: sound: cpu:sound-dai:0:1: missing phandle tag in 0 > arch/arm/boot/dts/exynos4412-trats2.dt.yaml: sound: cpu:sound-dai:0: [158, 0] is too long > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
On Sun, Aug 30, 2020 at 01:26:32PM +0200, Krzysztof Kozlowski wrote: > The "sound-dai" property has cells therefore phandle-array should be > used, even if it is just one phandle. This fixes dtbs_check warnings > like: Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.
On Sun, 30 Aug 2020 13:26:32 +0200, Krzysztof Kozlowski wrote: > The "sound-dai" property has cells therefore phandle-array should be > used, even if it is just one phandle. This fixes dtbs_check warnings > like: > > arch/arm/boot/dts/exynos4412-trats2.dt.yaml: sound: cpu:sound-dai:0:1: missing phandle tag in 0 > arch/arm/boot/dts/exynos4412-trats2.dt.yaml: sound: cpu:sound-dai:0: [158, 0] is too long Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/2] ASoC: midas-audio: Correct parsing sound-dai phandles commit: 3e7ba1c0432ef9a792b9c77d36f78037626303b0 [2/2] ASoC: odroid: Use unevaluatedProperties commit: a57307ca6b661e16f9435a25f376ac277c3de697 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
On Tue, Sep 01, 2020 at 12:03:49PM +0100, Mark Brown wrote: > On Sun, Aug 30, 2020 at 01:26:32PM +0200, Krzysztof Kozlowski wrote: > > The "sound-dai" property has cells therefore phandle-array should be > > used, even if it is just one phandle. This fixes dtbs_check warnings > > like: > > Please submit patches using subject lines reflecting the style for the > subsystem, this makes it easier for people to identify relevant patches. > Look at what existing commits in the area you're changing are doing and > make sure your subject lines visually resemble what they're doing. > There's no need to resubmit to fix this alone. The usual prefix for bindings is "dt-bindings: ..." so I wonder what type of prefix you expect: 1. ASoC: dt-bindings: ... 2. dt-bindings: ASoC: ... Which one of these? Best regards, Krzysztof
On Wed, Sep 02, 2020 at 11:10:38AM +0200, Krzysztof Kozlowski wrote: > On Tue, Sep 01, 2020 at 12:03:49PM +0100, Mark Brown wrote: > > Please submit patches using subject lines reflecting the style for the > > subsystem, this makes it easier for people to identify relevant patches. > The usual prefix for bindings is "dt-bindings: ..." so I wonder what > type of prefix you expect: > 1. ASoC: dt-bindings: ... This. Bindings aren't a separate subsystem.
On Wed, Sep 02, 2020 at 10:38:39AM +0100, Mark Brown wrote: > On Wed, Sep 02, 2020 at 11:10:38AM +0200, Krzysztof Kozlowski wrote: > > On Tue, Sep 01, 2020 at 12:03:49PM +0100, Mark Brown wrote: > > > > Please submit patches using subject lines reflecting the style for the > > > subsystem, this makes it easier for people to identify relevant patches. > > > The usual prefix for bindings is "dt-bindings: ..." so I wonder what > > type of prefix you expect: > > 1. ASoC: dt-bindings: ... > > This. Bindings aren't a separate subsystem. Sure, thanks! Best regards, Krzysztof
On Tue, Sep 01, 2020 at 03:50:05PM +0100, Mark Brown wrote: > On Sun, 30 Aug 2020 13:26:32 +0200, Krzysztof Kozlowski wrote: > > The "sound-dai" property has cells therefore phandle-array should be > > used, even if it is just one phandle. This fixes dtbs_check warnings > > like: > > > > arch/arm/boot/dts/exynos4412-trats2.dt.yaml: sound: cpu:sound-dai:0:1: missing phandle tag in 0 > > arch/arm/boot/dts/exynos4412-trats2.dt.yaml: sound: cpu:sound-dai:0: [158, 0] is too long > > Applied to > > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next > > Thanks! > > [1/2] ASoC: midas-audio: Correct parsing sound-dai phandles > commit: 3e7ba1c0432ef9a792b9c77d36f78037626303b0 > [2/2] ASoC: odroid: Use unevaluatedProperties > commit: a57307ca6b661e16f9435a25f376ac277c3de697 This one should be reverted/dropped too. Patch 1 is fine.
On Thu, Sep 03, 2020 at 10:47:38AM -0600, Rob Herring wrote: > > [2/2] ASoC: odroid: Use unevaluatedProperties > > commit: a57307ca6b661e16f9435a25f376ac277c3de697 > This one should be reverted/dropped too. Patch 1 is fine. There are others? What's the issue with them? It'd be easiest if you could send patches doing whatever reverts you're looking for.
On Thu, Sep 3, 2020 at 11:27 AM Mark Brown <broonie@kernel.org> wrote: > > On Thu, Sep 03, 2020 at 10:47:38AM -0600, Rob Herring wrote: > > > > [2/2] ASoC: odroid: Use unevaluatedProperties > > > commit: a57307ca6b661e16f9435a25f376ac277c3de697 > > > This one should be reverted/dropped too. Patch 1 is fine. > > There are others? What's the issue with them? It'd be easiest if you > could send patches doing whatever reverts you're looking for. Just 1 other you picked up. See "ASoC: samsung-i2s: Use unevaluatedProperties". Patches adding the missing properties (and restoring 'additionalProperties' on these 2 if not reverted) is the correct change. I've gone thru and NAKed all of the others so more don't get picked up. Rob
On Thu, 3 Sep 2020 at 19:49, Rob Herring <robh@kernel.org> wrote: > > On Thu, Sep 3, 2020 at 11:27 AM Mark Brown <broonie@kernel.org> wrote: > > > > On Thu, Sep 03, 2020 at 10:47:38AM -0600, Rob Herring wrote: > > > > > > [2/2] ASoC: odroid: Use unevaluatedProperties > > > > commit: a57307ca6b661e16f9435a25f376ac277c3de697 > > > > > This one should be reverted/dropped too. Patch 1 is fine. > > > > There are others? What's the issue with them? It'd be easiest if you > > could send patches doing whatever reverts you're looking for. > > Just 1 other you picked up. See "ASoC: samsung-i2s: Use > unevaluatedProperties". Patches adding the missing properties (and > restoring 'additionalProperties' on these 2 if not reverted) is the > correct change. > > I've gone thru and NAKed all of the others so more don't get picked up. Ah, my bad... Mark, I can send a follow up which restores the additionalProperties (so kind of revert of the second patch) and fixes the warning. Other way is that you just drop it and I will send a correct fix later. Sorry for the mess. Best regards, Krzysztpf
On Thu, Sep 03, 2020 at 08:08:51PM +0200, Krzysztof Kozlowski wrote: > On Thu, 3 Sep 2020 at 19:49, Rob Herring <robh@kernel.org> wrote: > > Just 1 other you picked up. See "ASoC: samsung-i2s: Use > > unevaluatedProperties". Patches adding the missing properties (and > > restoring 'additionalProperties' on these 2 if not reverted) is the > > correct change. > > I've gone thru and NAKed all of the others so more don't get picked up. > Ah, my bad... Mark, I can send a follow up which restores the > additionalProperties (so kind of revert of the second patch) and fixes > the warning. Other way is that you just drop it and I will send a > correct fix later. Sure, that sounds great - I'm just finishing up for today anyway so I'll look out for something tomorrow.
diff --git a/Documentation/devicetree/bindings/sound/samsung,midas-audio.yaml b/Documentation/devicetree/bindings/sound/samsung,midas-audio.yaml index 1c755de686f7..578928e67e5c 100644 --- a/Documentation/devicetree/bindings/sound/samsung,midas-audio.yaml +++ b/Documentation/devicetree/bindings/sound/samsung,midas-audio.yaml @@ -21,7 +21,8 @@ properties: type: object properties: sound-dai: - $ref: /schemas/types.yaml#/definitions/phandle + $ref: /schemas/types.yaml#/definitions/phandle-array + maxItems: 1 description: phandle to the I2S controller required: - sound-dai @@ -30,7 +31,8 @@ properties: type: object properties: sound-dai: - $ref: /schemas/types.yaml#/definitions/phandle + $ref: /schemas/types.yaml#/definitions/phandle-array + maxItems: 1 description: phandle to the WM1811 CODEC required: - sound-dai
The "sound-dai" property has cells therefore phandle-array should be used, even if it is just one phandle. This fixes dtbs_check warnings like: arch/arm/boot/dts/exynos4412-trats2.dt.yaml: sound: cpu:sound-dai:0:1: missing phandle tag in 0 arch/arm/boot/dts/exynos4412-trats2.dt.yaml: sound: cpu:sound-dai:0: [158, 0] is too long Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- .../devicetree/bindings/sound/samsung,midas-audio.yaml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)