diff mbox series

ASoC: Intel: KeemBay: Fix warning potential ! vs ~ typo

Message ID 20200904020904.19577-1-michael.wei.hong.sit@intel.com (mailing list archive)
State Accepted
Commit b40f708deb951c3d46857fe5aed9cea1a506585b
Headers show
Series ASoC: Intel: KeemBay: Fix warning potential ! vs ~ typo | expand

Commit Message

Sit, Michael Wei Hong Sept. 4, 2020, 2:09 a.m. UTC 
To set platform in slave mode setting the MASTER_MODE bit is not needed.
Removing !MASTER_MODE conditional to avoid potential errors and warning.

Signed-off-by: Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/intel/keembay/kmb_platform.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Brown Sept. 7, 2020, 6:05 p.m. UTC | #1 
On Fri, 4 Sep 2020 10:09:04 +0800, Michael Sit Wei Hong wrote:
> To set platform in slave mode setting the MASTER_MODE bit is not needed.
> Removing !MASTER_MODE conditional to avoid potential errors and warning.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: Intel: KeemBay: Fix warning potential ! vs ~ typo
      commit: b40f708deb951c3d46857fe5aed9cea1a506585b

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/sound/soc/intel/keembay/kmb_platform.c b/sound/soc/intel/keembay/kmb_platform.c
index ca25a6e40cc9..f54b710ee1c2 100644
--- a/sound/soc/intel/keembay/kmb_platform.c
+++ b/sound/soc/intel/keembay/kmb_platform.c
@@ -515,7 +515,7 @@  static int kmb_dai_hw_params(struct snd_pcm_substream *substream,
 
 		write_val = ((config->chan_nr / 2) << TDM_CHANNEL_CONFIG_BIT) |
 				(config->data_width << DATA_WIDTH_CONFIG_BIT) |
-				!MASTER_MODE | TDM_OPERATION;
+				TDM_OPERATION;
 
 		writel(write_val, kmb_i2s->pss_base + I2S_GEN_CFG_0);
 		break;