| Message ID | 20200923132600.10652-4-dmurphy@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/6] dt-bindings: tas2770: Add shutdown gpio property | expand |
On Wed, Sep 23, 2020 at 08:25:58AM -0500, Dan Murphy wrote: > Remove the property ti,asi-format as the driver only reads this property > and performs no action against it. We should probably leave the property as documented and move it to deprecated rather than delete the documentation entirely.
Mark On 9/23/20 10:51 AM, Mark Brown wrote: > On Wed, Sep 23, 2020 at 08:25:58AM -0500, Dan Murphy wrote: >> Remove the property ti,asi-format as the driver only reads this property >> and performs no action against it. > We should probably leave the property as documented and move it to > deprecated rather than delete the documentation entirely. I mulled this over to just deprecate the property and I know removing these ABIs are not highly accepted. But the support code for it was incomplete and if a user had it populated in the DT and we removed the support then there will be no functional change. This property was supposed to set the RX edge SBCLK detection but this is done based on the dai format. So removing the property will have no affect on the users. Dan
diff --git a/Documentation/devicetree/bindings/sound/tas2770.yaml b/Documentation/devicetree/bindings/sound/tas2770.yaml index 9fdf614add55..aa8c74575ac9 100644 --- a/Documentation/devicetree/bindings/sound/tas2770.yaml +++ b/Documentation/devicetree/bindings/sound/tas2770.yaml @@ -43,13 +43,6 @@ properties: $ref: /schemas/types.yaml#/definitions/uint32 description: TDM TX voltage sense time slot. - ti,asi-format: - $ref: /schemas/types.yaml#/definitions/uint32 - description: Sets TDM RX capture edge. - enum: - - 0 # Rising edge - - 1 # Falling edge - '#sound-dai-cells': const: 1
Remove the property ti,asi-format as the driver only reads this property and performs no action against it. Signed-off-by: Dan Murphy <dmurphy@ti.com> --- Documentation/devicetree/bindings/sound/tas2770.yaml | 7 ------- 1 file changed, 7 deletions(-)