diff mbox series

ASoC: ti: davinci-mcasp: Use &pdev->dev for early dev_warn

Message ID 20201008085400.19944-1-peter.ujfalusi@ti.com (mailing list archive)
State Accepted
Commit 18096cb0bcff1ebf4459ea5f6dc940d8eaf4b942
Headers show
Series ASoC: ti: davinci-mcasp: Use &pdev->dev for early dev_warn | expand

Commit Message

Peter Ujfalusi Oct. 8, 2020, 8:54 a.m. UTC
At this point mcasp->dev is not initialized and we would have NULL pointer
dereference if we would have failed to get the mem memory resource by
name.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 sound/soc/ti/davinci-mcasp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Brown Oct. 8, 2020, 10:01 p.m. UTC | #1
On Thu, 8 Oct 2020 11:54:00 +0300, Peter Ujfalusi wrote:
> At this point mcasp->dev is not initialized and we would have NULL pointer
> dereference if we would have failed to get the mem memory resource by
> name.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: ti: davinci-mcasp: Use &pdev->dev for early dev_warn
      commit: 18096cb0bcff1ebf4459ea5f6dc940d8eaf4b942

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/sound/soc/ti/davinci-mcasp.c b/sound/soc/ti/davinci-mcasp.c
index 3ffdd0f6292a..a6b72ad53b43 100644
--- a/sound/soc/ti/davinci-mcasp.c
+++ b/sound/soc/ti/davinci-mcasp.c
@@ -2155,7 +2155,7 @@  static int davinci_mcasp_probe(struct platform_device *pdev)
 
 	mem = platform_get_resource_byname(pdev, IORESOURCE_MEM, "mpu");
 	if (!mem) {
-		dev_warn(mcasp->dev,
+		dev_warn(&pdev->dev,
 			 "\"mpu\" mem resource not found, using index 0\n");
 		mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 		if (!mem) {