diff mbox series

ASoC: SOF: loader: handle all SOF_IPC_EXT types

Message ID 20201021182419.1160391-1-kai.vehmanen@linux.intel.com (mailing list archive)
State Accepted
Commit 6e5329c6e6032cd997400b43b8299f607a61883e
Headers show
Series ASoC: SOF: loader: handle all SOF_IPC_EXT types | expand

Commit Message

Kai Vehmanen Oct. 21, 2020, 6:24 p.m. UTC 
From: Bard Liao <yung-chuan.liao@linux.intel.com>

Do not emit a warning for extended firmware header fields that are
not used by kernel. This creates unnecessary noise to kernel logs like:

sof-audio-pci 0000:00:1f.3: warning: unknown ext header type 3 size 0x1c
sof-audio-pci 0000:00:1f.3: warning: unknown ext header type 4 size 0x10

Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
---
 sound/soc/sof/loader.c | 5 +++++
 1 file changed, 5 insertions(+)

- baseline: eb5a558705c7 commit ("ASoC: mediatek: mt8183-da7219: fix DAPM paths for rt1015")

Comments

Mark Brown Oct. 24, 2020, 12:28 a.m. UTC | #1 
On Wed, 21 Oct 2020 21:24:19 +0300, Kai Vehmanen wrote:
> Do not emit a warning for extended firmware header fields that are
> not used by kernel. This creates unnecessary noise to kernel logs like:
> 
> sof-audio-pci 0000:00:1f.3: warning: unknown ext header type 3 size 0x1c
> sof-audio-pci 0000:00:1f.3: warning: unknown ext header type 4 size 0x10

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: SOF: loader: handle all SOF_IPC_EXT types
      commit: 6e5329c6e6032cd997400b43b8299f607a61883e

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/sound/soc/sof/loader.c b/sound/soc/sof/loader.c
index 68ed454f7ddf..ba9ed66f98bc 100644
--- a/sound/soc/sof/loader.c
+++ b/sound/soc/sof/loader.c
@@ -118,6 +118,11 @@  int snd_sof_fw_parse_ext_data(struct snd_sof_dev *sdev, u32 bar, u32 offset)
 		case SOF_IPC_EXT_CC_INFO:
 			ret = get_cc_info(sdev, ext_hdr);
 			break;
+		case SOF_IPC_EXT_UNUSED:
+		case SOF_IPC_EXT_PROBE_INFO:
+		case SOF_IPC_EXT_USER_ABI_INFO:
+			/* They are supported but we don't do anything here */
+			break;
 		default:
 			dev_warn(sdev->dev, "warning: unknown ext header type %d size 0x%x\n",
 				 ext_hdr->type, ext_hdr->hdr.size);