From patchwork Wed Nov 4 15:57:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Codrin Ciubotariu X-Patchwork-Id: 11881335 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA83EC2D0A3 for ; Wed, 4 Nov 2020 15:58:51 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DDD402236F for ; Wed, 4 Nov 2020 15:58:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="jXxVqGId"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="vsez/aQZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DDD402236F Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 412441678; Wed, 4 Nov 2020 16:57:57 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 412441678 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1604505527; bh=1IXMDBOSCtaUZtiq9izDv17V26Pq9aWYb9Tw2O2fSxs=; h=From:To:Subject:Date:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=jXxVqGIdWP7o/Wna8rTECLiVq4/xnCmkmmVUKk4hnQNz+CHLN/W74OA9jcY7FwnRK f+DYtgm7nJyBjxwXD+qKR3XPmgAoMY+Av6tp3TnH7XVpO+quLhgt0Zjxx8SPYNpZfF FAKobRrRjR3iIzktf0wxcZ1+atNsDN0PGcVWLdnY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id BB889F80232; Wed, 4 Nov 2020 16:57:56 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 72747F80234; Wed, 4 Nov 2020 16:57:54 +0100 (CET) Received: from esa6.microchip.iphmx.com (esa6.microchip.iphmx.com [216.71.154.253]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id DE9F0F80229 for ; Wed, 4 Nov 2020 16:57:47 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz DE9F0F80229 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="vsez/aQZ" DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1604505468; x=1636041468; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=1IXMDBOSCtaUZtiq9izDv17V26Pq9aWYb9Tw2O2fSxs=; b=vsez/aQZ3w6JdVtZF3lYsutrcP9lgbeciYlBnPl2I2s5vBO2CFJV2OkY zbktNSxoCEdRKv8t0sTofKUoMpw+Cce8OQavK07mxAay4jB1WQVPT1PY3 QHuHdeEtAJMD4Lp/akBsRUh6qtZNZ1Ke416P7tQ+A+SyBNOJfHiKXePqW kVlM49kZPopPvxg6gOu+keQR6vuawz2CNHumb+5nLjnYoEXYMmfAeSD4v krYTJniogMS10i/FxHZ6lgM4U0hsHSqgitamjcdcyLYVG3bfd9fXG1vD7 cKcCjtZdaxOm8J+JPUe58ofnGd3/ZfzPruwG6tazRWdtenxN0L2SzqeAX Q==; IronPort-SDR: xmQk0RwZowrJeY6M1qYOR3nH7hBq/SFUF+bH3yXO4jsDjxPIRtmeRLh7IyMcx7f6vJBgDyTWtZ RL+ojKFAhSPa9MMv9a5RpWmut69xdcwpz2KEwJKNIZPIJ7Xg2uHhsB+bkwtBjZmvS7GGN/MyZI jcBtIJdLz50OLYiZ8D9JLvgHJzmXrsrnGhGoIVNhhbiNe5TdtWZgP+HMRPIaE0P4hkjyawhySB Cms0meRnCremStsCaNiNIIoqHTRHw477jNBZQG58GwARmfW2C3d/N3/5py9k74aHAtlsQzF7LY F40= X-IronPort-AV: E=Sophos;i="5.77,451,1596524400"; d="scan'208";a="32405234" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 04 Nov 2020 08:57:44 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Wed, 4 Nov 2020 08:57:43 -0700 Received: from rob-ult-m19940.amer.actel.com (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.1979.3 via Frontend Transport; Wed, 4 Nov 2020 08:57:40 -0700 From: Codrin Ciubotariu To: , , Subject: [PATCH] ASoC: mchp-spdiftx: Do not set Validity bit(s) Date: Wed, 4 Nov 2020 17:57:38 +0200 Message-ID: <20201104155738.68403-1-codrin.ciubotariu@microchip.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Cc: alexandre.belloni@bootlin.com, lgirdwood@gmail.com, nicolas.ferre@microchip.com, ludovic.desroches@microchip.com, broonie@kernel.org, Codrin Ciubotariu X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" The Validity bits (bit 28) must not be set in order to have the samples valid. Some controllers look for this bit and ignore the samples if it is set. Fixes: 06ca24e98e6b ("ASoC: mchp-spdiftx: add driver for S/PDIF TX Controller") Signed-off-by: Codrin Ciubotariu --- sound/soc/atmel/mchp-spdiftx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/atmel/mchp-spdiftx.c b/sound/soc/atmel/mchp-spdiftx.c index 82c1eecd2528..3bd350afb743 100644 --- a/sound/soc/atmel/mchp-spdiftx.c +++ b/sound/soc/atmel/mchp-spdiftx.c @@ -487,7 +487,6 @@ static int mchp_spdiftx_hw_params(struct snd_pcm_substream *substream, } mchp_spdiftx_channel_status_write(dev); spin_unlock_irqrestore(&ctrl->lock, flags); - mr |= SPDIFTX_MR_VALID1 | SPDIFTX_MR_VALID2; if (dev->gclk_enabled) { clk_disable_unprepare(dev->gclk);