diff mbox series

ASoC: atmel: mchp-spdifrx needs COMMON_CLK

Message ID 20201203223815.1353451-1-arnd@kernel.org (mailing list archive)
State Accepted
Commit 29275309b0e32bb838d67158c6b6e687275f43e9
Headers show
Series ASoC: atmel: mchp-spdifrx needs COMMON_CLK | expand

Commit Message

Arnd Bergmann Dec. 3, 2020, 10:38 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

Compile-testing this driver on an older platform without CONFIG_COMMON_CLK fails with

ERROR: modpost: "clk_set_min_rate" [sound/soc/atmel/snd-soc-mchp-spdifrx.ko] undefined!

Make this is a strict dependency.

Fixes: ef265c55c1ac ("ASoC: mchp-spdifrx: add driver for SPDIF RX")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 sound/soc/atmel/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Codrin Ciubotariu Dec. 4, 2020, 9:11 a.m. UTC | #1 
On 04.12.2020 00:38, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Compile-testing this driver on an older platform without CONFIG_COMMON_CLK fails with
> 
> ERROR: modpost: "clk_set_min_rate" [sound/soc/atmel/snd-soc-mchp-spdifrx.ko] undefined!
> 
> Make this is a strict dependency.
> 
> Fixes: ef265c55c1ac ("ASoC: mchp-spdifrx: add driver for SPDIF RX")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>

Thanks!

> ---
>   sound/soc/atmel/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig
> index bd8854bfd2ee..142373ec411a 100644
> --- a/sound/soc/atmel/Kconfig
> +++ b/sound/soc/atmel/Kconfig
> @@ -148,6 +148,7 @@ config SND_MCHP_SOC_SPDIFTX
>   config SND_MCHP_SOC_SPDIFRX
>          tristate "Microchip ASoC driver for boards using S/PDIF RX"
>          depends on OF && (ARCH_AT91 || COMPILE_TEST)
> +       depends on COMMON_CLK
>          select SND_SOC_GENERIC_DMAENGINE_PCM
>          select REGMAP_MMIO
>          help
> --
> 2.27.0
>
Mark Brown Dec. 4, 2020, 11:30 p.m. UTC | #2 
On Thu, 3 Dec 2020 23:38:05 +0100, Arnd Bergmann wrote:
> Compile-testing this driver on an older platform without CONFIG_COMMON_CLK fails with
> 
> ERROR: modpost: "clk_set_min_rate" [sound/soc/atmel/snd-soc-mchp-spdifrx.ko] undefined!
> 
> Make this is a strict dependency.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: atmel: mchp-spdifrx needs COMMON_CLK
      commit: 29275309b0e32bb838d67158c6b6e687275f43e9

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig
index bd8854bfd2ee..142373ec411a 100644
--- a/sound/soc/atmel/Kconfig
+++ b/sound/soc/atmel/Kconfig
@@ -148,6 +148,7 @@  config SND_MCHP_SOC_SPDIFTX
 config SND_MCHP_SOC_SPDIFRX
 	tristate "Microchip ASoC driver for boards using S/PDIF RX"
 	depends on OF && (ARCH_AT91 || COMPILE_TEST)
+	depends on COMMON_CLK
 	select SND_SOC_GENERIC_DMAENGINE_PCM
 	select REGMAP_MMIO
 	help