diff mbox series

[v2,1/3] ALSA: hda/ca0132 - Fix AE-5 rear headphone pincfg.

Message ID 20201208195223.424753-1-conmanx360@gmail.com (mailing list archive)
State Superseded
Headers show
Series [v2,1/3] ALSA: hda/ca0132 - Fix AE-5 rear headphone pincfg. | expand

Commit Message

Connor McAdams Dec. 8, 2020, 7:52 p.m. UTC
The Windows driver sets the pincfg for the AE-5's rear-headphone to
report as a microphone. This causes issues with Pulseaudio mistakenly
believing there is no headphone plugged in. In Linux, we should instead
set it to be a headphone.

Fixes: a6b0961b39896 ("ALSA: hda/ca0132 - fix AE-5 pincfg")
Cc: <stable@kernel.org>
Signed-off-by: Connor McAdams <conmanx360@gmail.com>
---
 sound/pci/hda/patch_ca0132.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

v2 changes:
- Add fixes references to previous commits that these patches now fix.

Comments

Takashi Iwai Dec. 8, 2020, 8:27 p.m. UTC | #1
On Tue, 08 Dec 2020 20:52:20 +0100,
Connor McAdams wrote:
> 
> The Windows driver sets the pincfg for the AE-5's rear-headphone to
> report as a microphone. This causes issues with Pulseaudio mistakenly
> believing there is no headphone plugged in. In Linux, we should instead
> set it to be a headphone.
> 
> Fixes: a6b0961b39896 ("ALSA: hda/ca0132 - fix AE-5 pincfg")
> Cc: <stable@kernel.org>
> Signed-off-by: Connor McAdams <conmanx360@gmail.com>

Thanks, applied all three patches now.


Takashi
Takashi Iwai Dec. 8, 2020, 8:33 p.m. UTC | #2
On Tue, 08 Dec 2020 21:27:45 +0100,
Takashi Iwai wrote:
> 
> On Tue, 08 Dec 2020 20:52:20 +0100,
> Connor McAdams wrote:
> > 
> > The Windows driver sets the pincfg for the AE-5's rear-headphone to
> > report as a microphone. This causes issues with Pulseaudio mistakenly
> > believing there is no headphone plugged in. In Linux, we should instead
> > set it to be a headphone.
> > 
> > Fixes: a6b0961b39896 ("ALSA: hda/ca0132 - fix AE-5 pincfg")
> > Cc: <stable@kernel.org>
> > Signed-off-by: Connor McAdams <conmanx360@gmail.com>
> 
> Thanks, applied all three patches now.

BTW, there is a bug report about AE-7.
Could you take a look?
  https://bugzilla.kernel.org/show_bug.cgi?id=209281


Takashi
diff mbox series

Patch

diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c
index 4fbec4258f58..e96db73c32f5 100644
--- a/sound/pci/hda/patch_ca0132.c
+++ b/sound/pci/hda/patch_ca0132.c
@@ -1223,7 +1223,7 @@  static const struct hda_pintbl ae5_pincfgs[] = {
 	{ 0x0e, 0x01c510f0 }, /* SPDIF In */
 	{ 0x0f, 0x01017114 }, /* Port A -- Rear L/R. */
 	{ 0x10, 0x01017012 }, /* Port D -- Center/LFE or FP Hp */
-	{ 0x11, 0x01a170ff }, /* Port B -- LineMicIn2 / Rear Headphone */
+	{ 0x11, 0x012170ff }, /* Port B -- LineMicIn2 / Rear Headphone */
 	{ 0x12, 0x01a170f0 }, /* Port C -- LineIn1 */
 	{ 0x13, 0x908700f0 }, /* What U Hear In*/
 	{ 0x18, 0x50d000f0 }, /* N/A */