diff mbox series

[next] ALSA: usb-audio: remove initialization of param_period_time_if_needed

Message ID 20210115154151.75022-1-colin.king@canonical.com (mailing list archive)
State New, archived
Headers show
Series [next] ALSA: usb-audio: remove initialization of param_period_time_if_needed | expand

Commit Message

Colin Ian King Jan. 15, 2021, 3:41 p.m. UTC
From: Colin Ian King <colin.king@canonical.com>

Variable param_period_time_if_needed is being initialized with a value
that is never read, the assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 sound/usb/pcm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Takashi Iwai Jan. 15, 2021, 3:52 p.m. UTC | #1
On Fri, 15 Jan 2021 16:41:51 +0100,
Colin King wrote:
> 
> From: Colin Ian King <colin.king@canonical.com>
> 
> Variable param_period_time_if_needed is being initialized with a value
> that is never read, the assignment is redundant and can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

This doesn't look applicable to the latest tree.
Could you check again?


thanks,

Takashi

> ---
>  sound/usb/pcm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
> index f71965bf815f..ed654338f6b7 100644
> --- a/sound/usb/pcm.c
> +++ b/sound/usb/pcm.c
> @@ -934,7 +934,7 @@ static int setup_hw_info(struct snd_pcm_runtime *runtime, struct snd_usb_substre
>  {
>  	const struct audioformat *fp;
>  	unsigned int pt, ptmin;
> -	int param_period_time_if_needed = -1;
> +	int param_period_time_if_needed;
>  	int err;
>  
>  	runtime->hw.formats = subs->formats;
> -- 
> 2.29.2
>
diff mbox series

Patch

diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
index f71965bf815f..ed654338f6b7 100644
--- a/sound/usb/pcm.c
+++ b/sound/usb/pcm.c
@@ -934,7 +934,7 @@  static int setup_hw_info(struct snd_pcm_runtime *runtime, struct snd_usb_substre
 {
 	const struct audioformat *fp;
 	unsigned int pt, ptmin;
-	int param_period_time_if_needed = -1;
+	int param_period_time_if_needed;
 	int err;
 
 	runtime->hw.formats = subs->formats;