diff mbox series

ASoC: siu: Fix build error by a wrong const prefix

Message ID 20210126154702.3974-1-tiwai@suse.de (mailing list archive)
State Accepted
Commit ae07f5c7c5e9ebca5b9d6471bb4b99a9da5c6d88
Headers show
Series ASoC: siu: Fix build error by a wrong const prefix | expand

Commit Message

Takashi Iwai Jan. 26, 2021, 3:47 p.m. UTC
A const prefix was put wrongly in the middle at the code refactoring
commit 932eaf7c7904 ("ASoC: sh: siu_pcm: remove snd_pcm_ops"), which
leads to a build error as:
  sound/soc/sh/siu_pcm.c:546:8: error: expected '{' before 'const'

Also, another inconsistency is that the declaration of siu_component
misses the const prefix.

This patch corrects both failures.

Fixes: 932eaf7c7904 ("ASoC: sh: siu_pcm: remove snd_pcm_ops")
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

Casually caught by a random build test after your latest PR.

 sound/soc/sh/siu.h     | 2 +-
 sound/soc/sh/siu_pcm.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Mark Brown Jan. 27, 2021, 5:13 p.m. UTC | #1
On Tue, 26 Jan 2021 16:47:02 +0100, Takashi Iwai wrote:
> A const prefix was put wrongly in the middle at the code refactoring
> commit 932eaf7c7904 ("ASoC: sh: siu_pcm: remove snd_pcm_ops"), which
> leads to a build error as:
>   sound/soc/sh/siu_pcm.c:546:8: error: expected '{' before 'const'
> 
> Also, another inconsistency is that the declaration of siu_component
> misses the const prefix.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: siu: Fix build error by a wrong const prefix
      commit: ae07f5c7c5e9ebca5b9d6471bb4b99a9da5c6d88

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/sound/soc/sh/siu.h b/sound/soc/sh/siu.h
index 6201840f1bc0..a675c36fc9d9 100644
--- a/sound/soc/sh/siu.h
+++ b/sound/soc/sh/siu.h
@@ -169,7 +169,7 @@  static inline u32 siu_read32(u32 __iomem *addr)
 #define SIU_BRGBSEL	(0x108 / sizeof(u32))
 #define SIU_BRRB	(0x10c / sizeof(u32))
 
-extern struct snd_soc_component_driver siu_component;
+extern const struct snd_soc_component_driver siu_component;
 extern struct siu_info *siu_i2s_data;
 
 int siu_init_port(int port, struct siu_port **port_info, struct snd_card *card);
diff --git a/sound/soc/sh/siu_pcm.c b/sound/soc/sh/siu_pcm.c
index 45c4320976ab..4785886df4f0 100644
--- a/sound/soc/sh/siu_pcm.c
+++ b/sound/soc/sh/siu_pcm.c
@@ -543,7 +543,7 @@  static void siu_pcm_free(struct snd_soc_component *component,
 	dev_dbg(pcm->card->dev, "%s\n", __func__);
 }
 
-struct const snd_soc_component_driver siu_component = {
+const struct snd_soc_component_driver siu_component = {
 	.name		= DRV_NAME,
 	.open		= siu_pcm_open,
 	.close		= siu_pcm_close,