diff mbox series

[2/2] ALSA: hda: Constify static attribute_group

Message ID 20210131001241.2278-3-rikard.falkeborn@gmail.com (mailing list archive)
State Accepted
Commit 0417fadab493b55093ba2590f4e66c828f7084fe
Headers show
Series ALSA: Constify static attribute_group structs | expand

Commit Message

Rikard Falkeborn Jan. 31, 2021, 12:12 a.m. UTC 
The only usage of hdac_dev_attr_group is to put its address in an array
of pointers to const attribute_group structs. Make it const to allow the
compiler to put it in read-only memory.

Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
---
 sound/hda/hdac_sysfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Takashi Iwai Jan. 31, 2021, 8:50 a.m. UTC | #1 
On Sun, 31 Jan 2021 01:12:41 +0100,
Rikard Falkeborn wrote:
> 
> The only usage of hdac_dev_attr_group is to put its address in an array
> of pointers to const attribute_group structs. Make it const to allow the
> compiler to put it in read-only memory.
> 
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>

Thanks, applied.


Takashi
diff mbox series

Patch

diff --git a/sound/hda/hdac_sysfs.c b/sound/hda/hdac_sysfs.c
index e56e83325903..0d7771fca9f0 100644
--- a/sound/hda/hdac_sysfs.c
+++ b/sound/hda/hdac_sysfs.c
@@ -66,7 +66,7 @@  static struct attribute *hdac_dev_attrs[] = {
 	NULL
 };
 
-static struct attribute_group hdac_dev_attr_group = {
+static const struct attribute_group hdac_dev_attr_group = {
 	.attrs	= hdac_dev_attrs,
 };