| Message ID | 20210301193328.2123511-1-festevam@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ee00e0bf7e4fe6c253219680b339add32686efee |
| Headers | show |
| Series | ASoC: wm8524: Do not print probe defer error | expand |
On Mon, Mar 01, 2021 at 04:33:28PM -0300, Fabio Estevam wrote: > On an imx8mq-evk the following error is seen: > > [ 1.375809] wm8524-codec audio-codec: Failed to get mute line: -517 > > It happens because the codec driver may probe prior to the imx gpio > driver, which causes a probe defer. > > Change to dev_err_probe() to avoid printing this error. > > Reported-by: Chris Healy <cphealy@gmail.com> > Signed-off-by: Fabio Estevam <festevam@gmail.com> > --- Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com> Thanks, Charles
On Mon, 1 Mar 2021 16:33:28 -0300, Fabio Estevam wrote: > On an imx8mq-evk the following error is seen: > > [ 1.375809] wm8524-codec audio-codec: Failed to get mute line: -517 > > It happens because the codec driver may probe prior to the imx gpio > driver, which causes a probe defer. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: wm8524: Do not print probe defer error commit: 59dffc7769d720aab10b8c70acfcf1dea4a493f3 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/codecs/wm8524.c b/sound/soc/codecs/wm8524.c index 4e9ab542f648..81f858f6bd67 100644 --- a/sound/soc/codecs/wm8524.c +++ b/sound/soc/codecs/wm8524.c @@ -227,7 +227,7 @@ static int wm8524_codec_probe(struct platform_device *pdev) wm8524->mute = devm_gpiod_get(&pdev->dev, "wlf,mute", GPIOD_OUT_LOW); if (IS_ERR(wm8524->mute)) { ret = PTR_ERR(wm8524->mute); - dev_err(&pdev->dev, "Failed to get mute line: %d\n", ret); + dev_err_probe(&pdev->dev, ret, "Failed to get mute line\n"); return ret; }
On an imx8mq-evk the following error is seen: [ 1.375809] wm8524-codec audio-codec: Failed to get mute line: -517 It happens because the codec driver may probe prior to the imx gpio driver, which causes a probe defer. Change to dev_err_probe() to avoid printing this error. Reported-by: Chris Healy <cphealy@gmail.com> Signed-off-by: Fabio Estevam <festevam@gmail.com> --- sound/soc/codecs/wm8524.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)