diff mbox series

[10/10] ASoC: wm_hubs: align function prototype

Message ID 20210311004332.120901-11-pierre-louis.bossart@linux.intel.com (mailing list archive)
State Accepted
Commit 8ea9e29cc7fc966885018628e123f4113f1ce4b2
Headers show
Series ASoC: codecs: wolfson: remove cppcheck warnings | expand

Commit Message

Pierre-Louis Bossart March 11, 2021, 12:43 a.m. UTC
cppcheck warnings:

sound/soc/codecs/wm_hubs.c:1194:11: style:inconclusive: Function
'wm_hubs_handle_analogue_pdata' argument 8 names different:
declaration 'micbias1_dly' definition
'micbias1_delay'. [funcArgNamesDifferent]
      int micbias1_delay, int micbias2_delay,
          ^
sound/soc/codecs/wm_hubs.h:59:11: note: Function
'wm_hubs_handle_analogue_pdata' argument 8 names different:
declaration 'micbias1_dly' definition 'micbias1_delay'.
      int micbias1_dly, int micbias2_dly,
          ^
sound/soc/codecs/wm_hubs.c:1194:11: note: Function
'wm_hubs_handle_analogue_pdata' argument 8 names different:
declaration 'micbias1_dly' definition 'micbias1_delay'.
      int micbias1_delay, int micbias2_delay,
          ^
sound/soc/codecs/wm_hubs.c:1194:31: style:inconclusive: Function
'wm_hubs_handle_analogue_pdata' argument 9 names different:
declaration 'micbias2_dly' definition
'micbias2_delay'. [funcArgNamesDifferent]
      int micbias1_delay, int micbias2_delay,
                              ^
sound/soc/codecs/wm_hubs.h:59:29: note: Function
'wm_hubs_handle_analogue_pdata' argument 9 names different:
declaration 'micbias2_dly' definition 'micbias2_delay'.
      int micbias1_dly, int micbias2_dly,
                            ^
sound/soc/codecs/wm_hubs.c:1194:31: note: Function
'wm_hubs_handle_analogue_pdata' argument 9 names different:
declaration 'micbias2_dly' definition 'micbias2_delay'.
      int micbias1_delay, int micbias2_delay,
                              ^

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/codecs/wm_hubs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Charles Keepax March 11, 2021, 9:32 a.m. UTC | #1
On Wed, Mar 10, 2021 at 06:43:32PM -0600, Pierre-Louis Bossart wrote:
> cppcheck warnings:
> 
> sound/soc/codecs/wm_hubs.c:1194:11: style:inconclusive: Function
> 'wm_hubs_handle_analogue_pdata' argument 8 names different:
> declaration 'micbias1_dly' definition
> 'micbias1_delay'. [funcArgNamesDifferent]
>       int micbias1_delay, int micbias2_delay,
>           ^
> sound/soc/codecs/wm_hubs.h:59:11: note: Function
> 'wm_hubs_handle_analogue_pdata' argument 8 names different:
> declaration 'micbias1_dly' definition 'micbias1_delay'.
>       int micbias1_dly, int micbias2_dly,
>           ^
> sound/soc/codecs/wm_hubs.c:1194:11: note: Function
> 'wm_hubs_handle_analogue_pdata' argument 8 names different:
> declaration 'micbias1_dly' definition 'micbias1_delay'.
>       int micbias1_delay, int micbias2_delay,
>           ^
> sound/soc/codecs/wm_hubs.c:1194:31: style:inconclusive: Function
> 'wm_hubs_handle_analogue_pdata' argument 9 names different:
> declaration 'micbias2_dly' definition
> 'micbias2_delay'. [funcArgNamesDifferent]
>       int micbias1_delay, int micbias2_delay,
>                               ^
> sound/soc/codecs/wm_hubs.h:59:29: note: Function
> 'wm_hubs_handle_analogue_pdata' argument 9 names different:
> declaration 'micbias2_dly' definition 'micbias2_delay'.
>       int micbias1_dly, int micbias2_dly,
>                             ^
> sound/soc/codecs/wm_hubs.c:1194:31: note: Function
> 'wm_hubs_handle_analogue_pdata' argument 9 names different:
> declaration 'micbias2_dly' definition 'micbias2_delay'.
>       int micbias1_delay, int micbias2_delay,
>                               ^
> 
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---

Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles
diff mbox series

Patch

diff --git a/sound/soc/codecs/wm_hubs.h b/sound/soc/codecs/wm_hubs.h
index 988b29e63060..a4ed9bd31426 100644
--- a/sound/soc/codecs/wm_hubs.h
+++ b/sound/soc/codecs/wm_hubs.h
@@ -56,7 +56,7 @@  extern int wm_hubs_handle_analogue_pdata(struct snd_soc_component *,
 					 int lineout1_diff, int lineout2_diff,
 					 int lineout1fb, int lineout2fb,
 					 int jd_scthr, int jd_thr,
-					 int micbias1_dly, int micbias2_dly,
+					 int micbias1_delay, int micbias2_delay,
 					 int micbias1_lvl, int micbias2_lvl);
 
 extern irqreturn_t wm_hubs_dcs_done(int irq, void *data);