| Message ID | 20210311004332.120901-3-pierre-louis.bossart@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b6021b5623b93da05375ae8060f8e8d5dcae0ba9 |
| Headers | show |
| Series | ASoC: codecs: wolfson: remove cppcheck warnings | expand |
On Wed, Mar 10, 2021 at 06:43:24PM -0600, Pierre-Louis Bossart wrote: > cppcheck warning: > > sound/soc/codecs/madera.c:3372:51: style:inconclusive: Function > 'madera_init_dai' argument 2 names different: declaration 'dai' > definition 'id'. [funcArgNamesDifferent] > int madera_init_dai(struct madera_priv *priv, int id) > ^ > sound/soc/codecs/madera.h:433:51: note: Function 'madera_init_dai' > argument 2 names different: declaration 'dai' definition 'id'. > int madera_init_dai(struct madera_priv *priv, int dai); > ^ > sound/soc/codecs/madera.c:3372:51: note: Function 'madera_init_dai' > argument 2 names different: declaration 'dai' definition 'id'. > int madera_init_dai(struct madera_priv *priv, int id) > ^ > > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > --- Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com> Thanks, Charles
diff --git a/sound/soc/codecs/madera.h b/sound/soc/codecs/madera.h index e0c0be59e2ef..09ad6e9bce4b 100644 --- a/sound/soc/codecs/madera.h +++ b/sound/soc/codecs/madera.h @@ -430,7 +430,7 @@ int madera_init_bus_error_irq(struct madera_priv *priv, int dsp_num, irq_handler_t handler); void madera_free_bus_error_irq(struct madera_priv *priv, int dsp_num); -int madera_init_dai(struct madera_priv *priv, int dai); +int madera_init_dai(struct madera_priv *priv, int id); int madera_set_output_mode(struct snd_soc_component *component, int output, bool differential);
cppcheck warning: sound/soc/codecs/madera.c:3372:51: style:inconclusive: Function 'madera_init_dai' argument 2 names different: declaration 'dai' definition 'id'. [funcArgNamesDifferent] int madera_init_dai(struct madera_priv *priv, int id) ^ sound/soc/codecs/madera.h:433:51: note: Function 'madera_init_dai' argument 2 names different: declaration 'dai' definition 'id'. int madera_init_dai(struct madera_priv *priv, int dai); ^ sound/soc/codecs/madera.c:3372:51: note: Function 'madera_init_dai' argument 2 names different: declaration 'dai' definition 'id'. int madera_init_dai(struct madera_priv *priv, int id) ^ Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> --- sound/soc/codecs/madera.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)