diff mbox series

[1/2] ASoC: rt5682: Add a mclk name property to the device tree

Message ID 20210322124706.17303-1-derek.fang@realtek.com (mailing list archive)
State New, archived
Headers show
Series [1/2] ASoC: rt5682: Add a mclk name property to the device tree | expand

Commit Message

Derek [方德義] March 22, 2021, 12:47 p.m. UTC 
From: "derek.fang" <derek@realtek.com>

The patch adds a new property to specify the mclk name which be used.

Signed-off-by: derek.fang <derek@realtek.com>

Comments

Mark Brown March 22, 2021, 1:01 p.m. UTC | #1 
On Mon, Mar 22, 2021 at 08:47:05PM +0800, derek.fang@realtek.com wrote:

> +- realtek,mclk-name : Specify the mclk name that codec uses as clock provider.

This is really non-idiomatic interface design for the device tree (or
anything really) - the names for the clocks are defined at the device
scope, it doesn't make sense to have a property like this.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/rt5682.txt b/Documentation/devicetree/bindings/sound/rt5682.txt
index cd8c53d8497e..bee935ef2974 100644
--- a/Documentation/devicetree/bindings/sound/rt5682.txt
+++ b/Documentation/devicetree/bindings/sound/rt5682.txt
@@ -46,6 +46,8 @@  Optional properties:
 
 - realtek,dmic-clk-driving-high : Set the high driving of the DMIC clock out.
 
+- realtek,mclk-name : Specify the mclk name that codec uses as clock provider.
+
 Pins on the device (for linking into audio routes) for RT5682:
 
   * DMIC L1