diff mbox series

[4/5] ASoC: codecs: lpass-rx-macro: remove useless return

Message ID 20210416191144.27006-5-pierre-louis.bossart@linux.intel.com (mailing list archive)
State Accepted
Commit 36924a12c32021a098fec621fb5ea707a72cd5b5
Headers show
Series ASoC: remove more cppcheck warnings | expand

Commit Message

Pierre-Louis Bossart April 16, 2021, 7:11 p.m. UTC
cppcheck warning:

sound/soc/codecs/lpass-rx-macro.c:1626:9: warning: Identical condition
and return expression 'ret', return value is always 0
 return ret;
sound/soc/codecs/lpass-rx-macro.c:1623:6: note: If condition 'ret' is
true, the function will return/exit
 if (ret)
sound/soc/codecs/lpass-rx-macro.c:1626:9: note: Returning identical
expression 'ret'
 return ret;

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Daniel Baluta <daniel.baluta@gmail.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
 sound/soc/codecs/lpass-rx-macro.c | 2 --
 1 file changed, 2 deletions(-)
diff mbox series


diff --git a/sound/soc/codecs/lpass-rx-macro.c b/sound/soc/codecs/lpass-rx-macro.c
index 8e6a47f152ad..b0ebfc8d180c 100644
--- a/sound/soc/codecs/lpass-rx-macro.c
+++ b/sound/soc/codecs/lpass-rx-macro.c
@@ -1620,8 +1620,6 @@  static int rx_macro_set_interpolator_rate(struct snd_soc_dai *dai,
 		return ret;
 	ret = rx_macro_set_mix_interpolator_rate(dai, rate_val, sample_rate);
-	if (ret)
-		return ret;
 	return ret;