diff mbox series

[RESEND] soundwire: dmi-quirks: remove duplicate initialization

Message ID 20210511025035.25233-1-yung-chuan.liao@linux.intel.com (mailing list archive)
State New, archived
Headers show
Series [RESEND] soundwire: dmi-quirks: remove duplicate initialization | expand

Commit Message

Bard Liao May 11, 2021, 2:50 a.m. UTC 
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

cppcheck warning:

drivers/soundwire/dmi-quirks.c:85:12: style: Redundant initialization
for 'map'. The initialized value is overwritten before it is
read. [redundantInitialization]
  for (map = dmi_id->driver_data; map->adr; map++) {
           ^
drivers/soundwire/dmi-quirks.c:83:25: note: map is initialized
  struct adr_remap *map = dmi_id->driver_data;
                        ^
drivers/soundwire/dmi-quirks.c:85:12: note: map is overwritten
  for (map = dmi_id->driver_data; map->adr; map++) {
           ^

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Daniel Baluta <daniel.baluta@gmail.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
---
 drivers/soundwire/dmi-quirks.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Vinod Koul May 11, 2021, 12:20 p.m. UTC | #1 
On 11-05-21, 10:50, Bard Liao wrote:
> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> 
> cppcheck warning:
> 
> drivers/soundwire/dmi-quirks.c:85:12: style: Redundant initialization
> for 'map'. The initialized value is overwritten before it is
> read. [redundantInitialization]
>   for (map = dmi_id->driver_data; map->adr; map++) {
>            ^
> drivers/soundwire/dmi-quirks.c:83:25: note: map is initialized
>   struct adr_remap *map = dmi_id->driver_data;
>                         ^
> drivers/soundwire/dmi-quirks.c:85:12: note: map is overwritten
>   for (map = dmi_id->driver_data; map->adr; map++) {
>            ^

Applied, thanks
diff mbox series

Patch

diff --git a/drivers/soundwire/dmi-quirks.c b/drivers/soundwire/dmi-quirks.c
index 82061c1d9835..5db0a2443a1d 100644
--- a/drivers/soundwire/dmi-quirks.c
+++ b/drivers/soundwire/dmi-quirks.c
@@ -80,7 +80,7 @@  u64 sdw_dmi_override_adr(struct sdw_bus *bus, u64 addr)
 	/* check if any address remap quirk applies */
 	dmi_id = dmi_first_match(adr_remap_quirk_table);
 	if (dmi_id) {
-		struct adr_remap *map = dmi_id->driver_data;
+		struct adr_remap *map;
 
 		for (map = dmi_id->driver_data; map->adr; map++) {
 			if (map->adr == addr) {