| Message ID | 20210526192957.449515-2-pierre-louis.bossart@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] ALSA: drivers: opl3: fix useless self-comparison | expand |
On Wed, 26 May 2021 21:29:57 +0200, Pierre-Louis Bossart wrote: > > Sparse throws the following warning: > > sound/pci/lx6464es/lx_core.c:677:34: error: self-comparison always > evaluates to false > > This comparison and error message make no sense, let's remove them. > > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Thanks, applied. Takashi
diff --git a/sound/pci/lx6464es/lx_core.c b/sound/pci/lx6464es/lx_core.c index f884f5a6a61c..d3f58a3d17fb 100644 --- a/sound/pci/lx6464es/lx_core.c +++ b/sound/pci/lx6464es/lx_core.c @@ -674,10 +674,6 @@ int lx_stream_set_format(struct lx6464es *chip, struct snd_pcm_runtime *runtime, u32 pipe_cmd = PIPE_INFO_TO_CMD(is_capture, pipe); u32 channels = runtime->channels; - if (runtime->channels != channels) - dev_err(chip->card->dev, "channel count mismatch: %d vs %d", - runtime->channels, channels); - mutex_lock(&chip->msg_lock); lx_message_init(&chip->rmh, CMD_0C_DEF_STREAM);
Sparse throws the following warning: sound/pci/lx6464es/lx_core.c:677:34: error: self-comparison always evaluates to false This comparison and error message make no sense, let's remove them. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> --- sound/pci/lx6464es/lx_core.c | 4 ---- 1 file changed, 4 deletions(-)