| Message ID | 20210528202047.GA39602@embeddedor (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [next] ASoC: ti: davinci-mcasp: Fix fall-through warning for Clang | expand |
On Fri, May 28, 2021 at 03:20:47PM -0500, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a goto statement instead of letting the code fall > through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> Reviewed-by: Kees Cook <keescook@chromium.org>
On 28/05/2021 23:20, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a goto statement instead of letting the code fall > through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > --- > JFYI: We had thousands of these sorts of warnings and now we are down > to just 25 in linux-next. This is one of those last remaining > warnings. > > sound/soc/ti/davinci-mcasp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/soc/ti/davinci-mcasp.c b/sound/soc/ti/davinci-mcasp.c > index b94220306d1a..587967720135 100644 > --- a/sound/soc/ti/davinci-mcasp.c > +++ b/sound/soc/ti/davinci-mcasp.c > @@ -2317,6 +2317,7 @@ static int davinci_mcasp_probe(struct platform_device *pdev) > break; > default: > dev_err(&pdev->dev, "No DMA controller found (%d)\n", ret); > + goto err; Would: fallthrough; be enough to silence the warning? If so, then I would prefer this version. > case -EPROBE_DEFER: > goto err; > } >
On 6/4/21 02:14, Péter Ujfalusi wrote: > > > On 28/05/2021 23:20, Gustavo A. R. Silva wrote: >> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning >> by explicitly adding a goto statement instead of letting the code fall >> through to the next case. >> >> Link: https://github.com/KSPP/linux/issues/115 >> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> >> --- >> JFYI: We had thousands of these sorts of warnings and now we are down >> to just 25 in linux-next. This is one of those last remaining >> warnings. >> >> sound/soc/ti/davinci-mcasp.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/sound/soc/ti/davinci-mcasp.c b/sound/soc/ti/davinci-mcasp.c >> index b94220306d1a..587967720135 100644 >> --- a/sound/soc/ti/davinci-mcasp.c >> +++ b/sound/soc/ti/davinci-mcasp.c >> @@ -2317,6 +2317,7 @@ static int davinci_mcasp_probe(struct platform_device *pdev) >> break; >> default: >> dev_err(&pdev->dev, "No DMA controller found (%d)\n", ret); >> + goto err; > > Would: > fallthrough; > > be enough to silence the warning? If so, then I would prefer this version. Yep.:) Done: https://lore.kernel.org/linux-hardening/20210604072714.GA244640@embeddedor/ Thanks -- Gustavo
diff --git a/sound/soc/ti/davinci-mcasp.c b/sound/soc/ti/davinci-mcasp.c index b94220306d1a..587967720135 100644 --- a/sound/soc/ti/davinci-mcasp.c +++ b/sound/soc/ti/davinci-mcasp.c @@ -2317,6 +2317,7 @@ static int davinci_mcasp_probe(struct platform_device *pdev) break; default: dev_err(&pdev->dev, "No DMA controller found (%d)\n", ret); + goto err; case -EPROBE_DEFER: goto err; }
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a goto statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> --- JFYI: We had thousands of these sorts of warnings and now we are down to just 25 in linux-next. This is one of those last remaining warnings. sound/soc/ti/davinci-mcasp.c | 1 + 1 file changed, 1 insertion(+)