| Message ID | 20210529184957.373232-1-bertrand@jacquin.bzh (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ASoC: snd-soc-lpass requires REGMAP_MMIO | expand |
On Sat, May 29, 2021 at 07:49:57PM +0100, Bertrand Jacquin wrote: > This does also apply to other Qualcomm Macro LPASS all making call to > devm_regmap_init_mmio() > --- > sound/soc/codecs/Kconfig | 4 ++++ A Signed-off-by is required for patches, please see submitting-patches.rst in the kernel tree for details on what this is and why it is important.
On Tuesday, June 01 2021 at 13:59:39 +0100, Mark Brown wrote: > On Sat, May 29, 2021 at 07:49:57PM +0100, Bertrand Jacquin wrote: > > > This does also apply to other Qualcomm Macro LPASS all making call to > > devm_regmap_init_mmio() > > --- > > sound/soc/codecs/Kconfig | 4 ++++ > > A Signed-off-by is required for patches, please see submitting-patches.rst > in the kernel tree for details on what this is and why it is important. This sounds legit, I have submitted an updated version. Cheers,
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 1c87b42606c9..f5614f47f44d 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -1824,18 +1824,22 @@ config SND_SOC_TPA6130A2 config SND_SOC_LPASS_WSA_MACRO depends on COMMON_CLK + select REGMAP_MMIO tristate "Qualcomm WSA Macro in LPASS(Low Power Audio SubSystem)" config SND_SOC_LPASS_VA_MACRO depends on COMMON_CLK + select REGMAP_MMIO tristate "Qualcomm VA Macro in LPASS(Low Power Audio SubSystem)" config SND_SOC_LPASS_RX_MACRO depends on COMMON_CLK + select REGMAP_MMIO tristate "Qualcomm RX Macro in LPASS(Low Power Audio SubSystem)" config SND_SOC_LPASS_TX_MACRO depends on COMMON_CLK + select REGMAP_MMIO tristate "Qualcomm TX Macro in LPASS(Low Power Audio SubSystem)" endmenu
With CONFIG_SND_SOC_LPASS_RX_MACRO=m and CONFIG_REGMAP_MMIO undefined, build fails with the following error make -f /var/tmp/portage/sys-kernel/stable-sources-5.12.8/work/linux-5.12.8-stable/scripts/Makefile.modpost sed 's/\.ko$/\.o/' modules.order | scripts/mod/modpost -E -o modules-only.symvers -i vmlinux.symvers -T - ERROR: modpost: "__devm_regmap_init_mmio_clk" [sound/soc/codecs/snd-soc-lpass-rx-macro.ko] undefined! This does also apply to other Qualcomm Macro LPASS all making call to devm_regmap_init_mmio() --- sound/soc/codecs/Kconfig | 4 ++++ 1 file changed, 4 insertions(+)