| Message ID | 20210604030045.7360-1-wanjiabing@vivo.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ASoC: Remove unneeded semicolon in rk817_codec.c | expand |
On Fri, Jun 04, 2021 at 11:00:23AM +0800, Wan Jiabing wrote: > Fix following coccicheck warning: > ./sound/soc/codecs/rk817_codec.c:49:2-3: Unneeded semicolon This doesn't apply against current code, please check and resend.
Hi, Mark >On Fri, Jun 04, 2021 at 11:00:23AM +0800, Wan Jiabing wrote: >> Fix following coccicheck warning: >> ./sound/soc/codecs/rk817_codec.c:49:2-3: Unneeded semicolon > >This doesn't apply against current code, please check and resend. I fixed this based on next-20210603. And this also applies against next-20210604. It might be my fault that I didn't decribe the version clearly. Should I write some description at subject line when working on ASoC of linux-next? Thanks, Jiabing
On Sat, Jun 05, 2021 at 08:58:31AM +0800, Jiabing Wan wrote: > >On Fri, Jun 04, 2021 at 11:00:23AM +0800, Wan Jiabing wrote: > >> Fix following coccicheck warning: > >> ./sound/soc/codecs/rk817_codec.c:49:2-3: Unneeded semicolon > > > >This doesn't apply against current code, please check and resend. > I fixed this based on next-20210603. > And this also applies against next-20210604. > It might be my fault that I didn't decribe the version clearly. > Should I write some description at subject line when working on ASoC of linux-next? I tried to apply this against my current -next targetted code, it's possible some change happened since the last time -next was built.
diff --git a/sound/soc/codecs/rk817_codec.c b/sound/soc/codecs/rk817_codec.c index fd3a5ba034a9..414d21f22a05 100644 --- a/sound/soc/codecs/rk817_codec.c +++ b/sound/soc/codecs/rk817_codec.c @@ -46,7 +46,7 @@ static int rk817_init(struct snd_soc_component *component) if (rk817->mic_in_differential) { snd_soc_component_update_bits(component, RK817_CODEC_AMIC_CFG0, MIC_DIFF_MASK, MIC_DIFF_EN); - }; + } return 0; }
Fix following coccicheck warning: ./sound/soc/codecs/rk817_codec.c:49:2-3: Unneeded semicolon Signed-off-by: Wan Jiabing <wanjiabing@vivo.com> --- sound/soc/codecs/rk817_codec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)