diff mbox series

[v1] ASoC: rt5631: Fix regcache sync errors on resume

Message ID 20210712005011.28536-1-digetx@gmail.com (mailing list archive)
State Accepted
Commit c71f78a662611fe2c67f3155da19b0eff0f29762
Headers show
Series [v1] ASoC: rt5631: Fix regcache sync errors on resume | expand

Commit Message

Dmitry Osipenko July 12, 2021, 12:50 a.m. UTC 
From: Maxim Schwalm <maxim.schwalm@gmail.com>

The ALC5631 does not like multi-write accesses, avoid them. This fixes:

rt5631 4-001a: Unable to sync registers 0x3a-0x3c. -121

errors on resume from suspend (and all registers after the registers in
the error not being synced).

Inspired by commit 2d30e9494f1e ("ASoC: rt5651: Fix regcache sync errors
on resume") from Hans de Geode, which fixed the same errors on ALC5651.

Signed-off-by: Maxim Schwalm <maxim.schwalm@gmail.com>
---
 sound/soc/codecs/rt5631.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Mark Brown July 14, 2021, 3:55 p.m. UTC | #1 
On Mon, 12 Jul 2021 03:50:11 +0300, Dmitry Osipenko wrote:
> The ALC5631 does not like multi-write accesses, avoid them. This fixes:
> 
> rt5631 4-001a: Unable to sync registers 0x3a-0x3c. -121
> 
> errors on resume from suspend (and all registers after the registers in
> the error not being synced).
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: rt5631: Fix regcache sync errors on resume
      commit: c71f78a662611fe2c67f3155da19b0eff0f29762

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/sound/soc/codecs/rt5631.c b/sound/soc/codecs/rt5631.c
index 3000bc128b5b..38356ea2bd6e 100644
--- a/sound/soc/codecs/rt5631.c
+++ b/sound/soc/codecs/rt5631.c
@@ -1695,6 +1695,8 @@  static const struct regmap_config rt5631_regmap_config = {
 	.reg_defaults = rt5631_reg,
 	.num_reg_defaults = ARRAY_SIZE(rt5631_reg),
 	.cache_type = REGCACHE_RBTREE,
+	.use_single_read = true,
+	.use_single_write = true,
 };
 
 static int rt5631_i2c_probe(struct i2c_client *i2c,