| Message ID | 20210728104416.636591-1-tanureal@opensource.cirrus.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | acbf58e530416e167c3b323111f4013d9f2b0a7d |
| Headers | show |
| Series | ASoC: wm_adsp: Let soc_cleanup_component_debugfs remove debugfs | expand |
On Wed, 28 Jul 2021 11:44:16 +0100, Lucas Tanure wrote: > soc_cleanup_component_debugfs will debugfs_remove_recursive > the component->debugfs_root, so adsp doesn't need to also > remove the same entry. > By doing that adsp also creates a race with core component, > which causes a NULL pointer dereference Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: wm_adsp: Let soc_cleanup_component_debugfs remove debugfs commit: acbf58e530416e167c3b323111f4013d9f2b0a7d All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c index b395df1eb72d..bbe27ab3b1fc 100644 --- a/sound/soc/codecs/wm_adsp.c +++ b/sound/soc/codecs/wm_adsp.c @@ -747,7 +747,6 @@ static void wm_adsp2_init_debugfs(struct wm_adsp *dsp, static void wm_adsp2_cleanup_debugfs(struct wm_adsp *dsp) { wm_adsp_debugfs_clear(dsp); - debugfs_remove_recursive(dsp->debugfs_root); } #else static inline void wm_adsp2_init_debugfs(struct wm_adsp *dsp,
soc_cleanup_component_debugfs will debugfs_remove_recursive the component->debugfs_root, so adsp doesn't need to also remove the same entry. By doing that adsp also creates a race with core component, which causes a NULL pointer dereference Signed-off-by: Lucas Tanure <tanureal@opensource.cirrus.com> --- sound/soc/codecs/wm_adsp.c | 1 - 1 file changed, 1 deletion(-)