diff mbox series

ALSA: pcm - fix mmap capability check for the snd-dummy driver

Message ID 20210730090254.612478-1-perex@perex.cz (mailing list archive)
State Accepted
Commit 852a8a97776a153be2e6c803218eced45f37a19c
Headers show
Series ALSA: pcm - fix mmap capability check for the snd-dummy driver | expand

Commit Message

Jaroslav Kysela July 30, 2021, 9:02 a.m. UTC
The snd-dummy driver (fake_buffer configuration) uses the ops->page
callback for the mmap operations. Allow mmap for this case, too.

Cc: <stable@vger.kernel.org>
Fixes: c4824ae7db41 ("ALSA: pcm: Fix mmap capability check")
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
---
 sound/core/pcm_native.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Takashi Iwai July 30, 2021, 6:20 p.m. UTC | #1
On Fri, 30 Jul 2021 11:02:54 +0200,
Jaroslav Kysela wrote:
> 
> The snd-dummy driver (fake_buffer configuration) uses the ops->page
> callback for the mmap operations. Allow mmap for this case, too.
> 
> Cc: <stable@vger.kernel.org>
> Fixes: c4824ae7db41 ("ALSA: pcm: Fix mmap capability check")
> Signed-off-by: Jaroslav Kysela <perex@perex.cz>

Applied, thanks.


Takashi
diff mbox series

Patch

diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
index 6a2971a7e6a1..09c0e2a6489c 100644
--- a/sound/core/pcm_native.c
+++ b/sound/core/pcm_native.c
@@ -246,7 +246,7 @@  static bool hw_support_mmap(struct snd_pcm_substream *substream)
 	if (!(substream->runtime->hw.info & SNDRV_PCM_INFO_MMAP))
 		return false;
 
-	if (substream->ops->mmap)
+	if (substream->ops->mmap || substream->ops->page)
 		return true;
 
 	switch (substream->dma_buffer.dev.type) {