From patchwork Wed Sep 1 16:40:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 12469833 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12262C4320E for ; Wed, 1 Sep 2021 16:41:41 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E589261053 for ; Wed, 1 Sep 2021 16:41:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E589261053 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id BD7841771; Wed, 1 Sep 2021 18:40:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz BD7841771 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1630514497; bh=IgcW+d5/MtmXnoDhkwyXEn1B10t2koIKwxRxHQAt+QA=; h=From:To:Subject:Date:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=p2t9i4N3uA6aeRaignhRQG97Rd6PEkoWBsTGXw9UvKwCljDIwuIpFKuIIlDxxjyT7 iW4jgz+DKRXfi8A0+CTKm4oGucK4vXK4EuU2fCBk87lj+t8mbFe4hZyRKYTus26Ip3 ggrvf6b4Nc3SnGcsxbimyN+8hGKjh+RS2KCnYmZA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 64705F80227; Wed, 1 Sep 2021 18:40:47 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7209EF80218; Wed, 1 Sep 2021 18:40:46 +0200 (CEST) Received: from conuserg-10.nifty.com (conuserg-10.nifty.com [210.131.2.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A5702F80218 for ; Wed, 1 Sep 2021 18:40:42 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A5702F80218 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=nifty.com header.i=@nifty.com header.b="RmYm1BYT" Received: from localhost.localdomain (133-32-232-101.west.xps.vectant.ne.jp [133.32.232.101]) (authenticated) by conuserg-10.nifty.com with ESMTP id 181GeCO2005174; Thu, 2 Sep 2021 01:40:12 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-10.nifty.com 181GeCO2005174 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1630514413; bh=sQ2RhCsMu7aC76iwNKL9hAmPl8fQjIe1J0BMr9NvZ0o=; h=From:To:Cc:Subject:Date:From; b=RmYm1BYTcVeJRHPm7je0GVran6Qp+4DLC45oR77rSi4UO6CSNc8eM3OJJgPiqHIZq yfmAG7FOOTugHXxovjhfvPFwwQ6oBbCbIIhzlHjKsOv1fQjNxRJ1sVryoPai+ZyAt9 Nu9DmxfAeGyORCVP6trNudIw/me93dZBun5VPxnN0cgoAx9pUvC9ay3v8rqqi54fNm gPJNmJT08CgJnP8N4APonhJGQQRhIRcrnk43GkCLv0Y5HtiWC5Br5GT3h+rxe6jAe1 ZisgioWcqZbCGyX3W+KoFsot35itxdScZ4oLkicRBlt1fRBzMI4HUdQ2P8ve8jN2n+ XuZpYroh1dGzw== X-Nifty-SrcIP: [133.32.232.101] From: Masahiro Yamada To: ALSA Development Mailing List Subject: [PATCH] ASoC: ti: rename CONFIG_SND_SOC_DM365_VOICE_CODEC_MODULE Date: Thu, 2 Sep 2021 01:40:09 +0900 Message-Id: <20210901164009.1546967-1-masahiroy@kernel.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Cc: =?unknown-8bit?q?Arnd_Bergmann_=3Carnd=40arndb=2Ede=3E=2C_linux-kernel?= =?unknown-8bit?q?=40vger=2Ekernel=2Eorg=2C_Masahiro_Yamada_=3Cmasahiroy=40k?= =?unknown-8bit?q?ernel=2Eorg=3E=2C_Takashi_Iwai_=3Ctiwai=40suse=2Ecom=3E=2C?= =?unknown-8bit?q?_Liam_Girdwood_=3Clgirdwood=40gmail=2Ecom=3E=2C_Mark_Brown?= =?unknown-8bit?q?_=3Cbroonie=40kernel=2Eorg=3E=2C_P=8F=AB=B1ter_Ujfalusi__?= =?unknown-8bit?q?=3Cpeter=2Eujfalusi=40gmail=2Ecom=3E?= X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Kconfig generates include/generated/autoconf.h to make CONFIG options available to the pre-processor. Symbols with the value 'm' are suffixed with '_MODULE' Here is a conflict; CONFIG_FOO=m results in '#define CONFIG_FOO_MODULE 1', but CONFIG_FOO_MODULE=y also results in the same define. Also, CONFIG options that end with '_MODULE' confuse the Kconfig/fixdep interaction; fixdep always assumes CONFIG_FOO_MODULE comes from CONFIG_FOO=m, so the dependency is not properly tracked for symbols that end with '_MODULE'. For these reasons, CONFIG options that end with '_MODULE' should be avoided in general. (I am planning on adding a check in Kconfig.) This is the only case in the current kernel. The new option name was suggested by Péter Ujfalusi. [1] [1] https://lore.kernel.org/all/d9e777dc-d274-92ee-4d77-711bfd553611@gmail.com/ Fixes: 147162f57515 ("ASoC: ti: fix SND_SOC_DM365_VOICE_CODEC dependencies") Signed-off-by: Masahiro Yamada Acked-by: Peter Ujfalusi --- sound/soc/ti/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/ti/Kconfig b/sound/soc/ti/Kconfig index 698d7bc84dcf..3260a30d3d54 100644 --- a/sound/soc/ti/Kconfig +++ b/sound/soc/ti/Kconfig @@ -211,7 +211,7 @@ config SND_SOC_DM365_VOICE_CODEC Say Y if you want to add support for SoC On-chip voice codec endchoice -config SND_SOC_DM365_VOICE_CODEC_MODULE +config SND_SOC_DM365_SELECT_VOICE_CODECS def_tristate y depends on SND_SOC_DM365_VOICE_CODEC && SND_SOC select MFD_DAVINCI_VOICECODEC