From patchwork Fri Sep 24 19:24:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Louis Bossart X-Patchwork-Id: 12516729 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97E6DC433F5 for ; Fri, 24 Sep 2021 19:26:34 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FA6360F0F for ; Fri, 24 Sep 2021 19:26:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1FA6360F0F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7FD501669; Fri, 24 Sep 2021 21:25:42 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7FD501669 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1632511592; bh=lvLZpgNGJmLiT2rstWNmbmSQYfcZAfafkMyz2t0mAaU=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=bqb+IYdMQJ2xta2AeCOfxcnmRfAkWyK/CdW4CYLVG7ayZ/ngYQoVgQYI82cwdu3Zw dU6Lv/tBXiF+GJuk2+wEVys0SlW/0HBCOpL7s6myBGtKYm5H82qJoN1uK6XgEcEsF7 Qz3qMpKgbJv0PK6rmCP+8gKzQLiWtknd/IWTGJHA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 6B483F804E3; Fri, 24 Sep 2021 21:24:57 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 09D85F804D6; Fri, 24 Sep 2021 21:24:55 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 51523F8013F for ; Fri, 24 Sep 2021 21:24:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 51523F8013F X-IronPort-AV: E=McAfee;i="6200,9189,10117"; a="203643404" X-IronPort-AV: E=Sophos;i="5.85,320,1624345200"; d="scan'208";a="203643404" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2021 12:24:38 -0700 X-IronPort-AV: E=Sophos;i="5.85,320,1624345200"; d="scan'208";a="551922495" Received: from bordone-mobl1.amr.corp.intel.com (HELO pbossart-mobl3.intel.com) ([10.209.164.235]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2021 12:24:37 -0700 From: Pierre-Louis Bossart To: alsa-devel@alsa-project.org Subject: [RFC PATCH 2/4] ALSA: hda: hdac_stream: reset assigned_key in stream_release() Date: Fri, 24 Sep 2021 14:24:15 -0500 Message-Id: <20210924192417.169243-3-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210924192417.169243-1-pierre-louis.bossart@linux.intel.com> References: <20210924192417.169243-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Cc: tiwai@suse.de, vkoul@kernel.org, broonie@kernel.org, Cezary Rojewski , Pierre-Louis Bossart X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" The 'assigned_key' field is set in assign() and never reset. For symmetry set to zero in release(). Signed-off-by: Pierre-Louis Bossart --- sound/hda/hdac_stream.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/hda/hdac_stream.c b/sound/hda/hdac_stream.c index 9867555883c3..3ae23c50d505 100644 --- a/sound/hda/hdac_stream.c +++ b/sound/hda/hdac_stream.c @@ -333,6 +333,7 @@ void snd_hdac_stream_release(struct hdac_stream *azx_dev) spin_lock_irq(&bus->reg_lock); azx_dev->opened = 0; azx_dev->running = 0; + azx_dev->assigned_key = 0; azx_dev->substream = NULL; spin_unlock_irq(&bus->reg_lock); }