From patchwork Mon Sep 27 09:54:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 12519507 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11941C433F5 for ; Mon, 27 Sep 2021 09:55:57 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85BB260F43 for ; Mon, 27 Sep 2021 09:55:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 85BB260F43 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id EBABB1676; Mon, 27 Sep 2021 11:55:04 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz EBABB1676 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1632736555; bh=i8ymyzqgvI3wLotGeaYebjXlqYY+zZQePxuRiKJ8yDI=; h=From:To:Subject:Date:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=VFH1ktY7NYl3Pgqs5hxSTaQLUqOFg2/OL2g0bDSml7e+TXWmhc+4NzVCkmQWuCZRf ehy61hBYIPOhX0z9nTNd/R8mActiMi1fy/A4IGV1RL2qR+Zx4h0Uc/mmdnLeQidV/9 7UXQFg6TFYQoj6VddoOT+qQXGG7ZnZtJ/Qig7RLI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 77582F801F7; Mon, 27 Sep 2021 11:55:04 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 60F99F80227; Mon, 27 Sep 2021 11:55:03 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5DF96F801EC for ; Mon, 27 Sep 2021 11:54:56 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5DF96F801EC Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cAhI7i4/" Received: by mail.kernel.org (Postfix) with ESMTPSA id 7C0CF60F70; Mon, 27 Sep 2021 09:54:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632736494; bh=i8ymyzqgvI3wLotGeaYebjXlqYY+zZQePxuRiKJ8yDI=; h=From:To:Cc:Subject:Date:From; b=cAhI7i4/kvjjIQ8w6lFk9uJKpSBk49kmUx+eOhilqKcrDvvWOCZP4vxNPLALMVnK4 2WsbCOyVsrkqDV6Z2AJ2DMxHpEDoP5asyOCKZmtHPY12LPsZpqZzWGwWC2NTl7oCkI XR1b7RoT46auZGQEnXZkOAa/J5tN1icDYh0fU/IvPzYWE1gcrroTu3j82+Mct9Tv/U n2I7OAoa7f1JVogt2FlEqAPhI6eS8mC85XugcNe1T5zUZKehWz/99mcV+KXZxS+FGZ uI8OgL37A88pA2rYMjnfFVlDd8urJ4PMr/1HCjtYrhnT1QPk44qpGBwyTeHMrp0tNy nYC8AhBL5k6Gg== From: Arnd Bergmann To: Krzysztof Kozlowski , Sylwester Nawrocki , Liam Girdwood , Mark Brown Subject: [PATCH] ASoC: samsung: add missing "fallthrough;" Date: Mon, 27 Sep 2021 11:54:34 +0200 Message-Id: <20210927095449.1070639-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Takashi Iwai , Arnd Bergmann X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" From: Arnd Bergmann With gcc, we get a warning in this file: In file included from include/linux/io.h:13, from sound/soc/samsung/s3c-i2s-v2.c:16: sound/soc/samsung/s3c-i2s-v2.c: In function 's3c2412_i2s_trigger': arch/arm/include/asm/io.h:92:22: error: this statement may fall through [-Werror=implicit-fallthrough=] #define __raw_writel __raw_writel ^ arch/arm/include/asm/io.h:299:29: note: in expansion of macro '__raw_writel' #define writel_relaxed(v,c) __raw_writel((__force u32) cpu_to_le32(v),c) ^~~~~~~~~~~~ arch/arm/include/asm/io.h:307:36: note: in expansion of macro 'writel_relaxed' #define writel(v,c) ({ __iowmb(); writel_relaxed(v,c); }) ^~~~~~~~~~~~~~ sound/soc/samsung/s3c-i2s-v2.c:398:3: note: in expansion of macro 'writel' writel(0x0, i2s->regs + S3C2412_IISFIC); ^~~~~~ sound/soc/samsung/s3c-i2s-v2.c:400:2: note: here case SNDRV_PCM_TRIGGER_RESUME: ^~~~ From all I can tell, this was indeed meant to fall through, so add "fallthrough;" statement to avoid the warning. Signed-off-by: Arnd Bergmann Reviewed-by: Krzysztof Kozlowski --- sound/soc/samsung/s3c-i2s-v2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/samsung/s3c-i2s-v2.c b/sound/soc/samsung/s3c-i2s-v2.c index e9481187a08c..de66cc422e6e 100644 --- a/sound/soc/samsung/s3c-i2s-v2.c +++ b/sound/soc/samsung/s3c-i2s-v2.c @@ -397,6 +397,8 @@ static int s3c2412_i2s_trigger(struct snd_pcm_substream *substream, int cmd, /* clear again, just in case */ writel(0x0, i2s->regs + S3C2412_IISFIC); + fallthrough; + case SNDRV_PCM_TRIGGER_RESUME: case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: if (!i2s->master) {