Double snd_dlobj_unlock()

Commit Message

GitHub issues - opened Oct. 7, 2021, 10:04 a.m. UTC

alsa-project/alsa-lib issue #181 was opened from johado:

In dlmisc.c:snd_dlobj_cache_get0() there is a call to snd_dlobj_unlock() in the __err: path which should not be there.
All lock/unlock are done by the callers to this function.


Issue URL     : https://github.com/alsa-project/alsa-lib/issues/181
Repository URL: https://github.com/alsa-project/alsa-lib

Patch

--- a/src/dlmisc.c
+++ b/src/dlmisc.c
@@ -359,7 +359,6 @@  snd_dlobj_cache_get0(const char *lib, const char *name,
                free(c);
              __err:
                snd_dlclose(dlobj);
-               snd_dlobj_unlock();
                return NULL;
        }
        c->dlobj = dlobj;