diff mbox series

[1/2,next] ASoC: rockchip: i2s-tdm: Remove call to rockchip_i2s_ch_to_io

Message ID 20211008095430.62680-1-colin.king@canonical.com (mailing list archive)
State Accepted
Commit 74daadc7fde5dc3326ba2158a60c1c028f2e19b9
Headers show
Series [1/2,next] ASoC: rockchip: i2s-tdm: Remove call to rockchip_i2s_ch_to_io | expand

Commit Message

Colin King Oct. 8, 2021, 9:54 a.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

The call to rockchip_i2s_ch_to_io is only useful for its return
value which is not being used. The function call also has no
side effects, the call is effectively useless and can be removed.

Addresses-Coverity: ("Useless call")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 sound/soc/rockchip/rockchip_i2s_tdm.c | 2 --
 1 file changed, 2 deletions(-)
diff mbox series

Patch

diff --git a/sound/soc/rockchip/rockchip_i2s_tdm.c b/sound/soc/rockchip/rockchip_i2s_tdm.c
index b08b15071993..cc5a2f9d3948 100644
--- a/sound/soc/rockchip/rockchip_i2s_tdm.c
+++ b/sound/soc/rockchip/rockchip_i2s_tdm.c
@@ -848,8 +848,6 @@  static int rockchip_i2s_io_multiplex(struct snd_pcm_substream *substream,
 				to_ch_num(val), usable_chs);
 			return -EINVAL;
 		}
-
-		rockchip_i2s_ch_to_io(val, false);
 	}
 
 	val <<= i2s_tdm->soc_data->grf_shift;