diff mbox series

[v2,2/3] ASoC: SOF: topology: don't use list_for_each_entry_reverse()

Message ID 20211123171606.129350-2-kai.vehmanen@linux.intel.com (mailing list archive)
State Accepted
Commit fb71d03b29bcbd8c03798d36e7b2a2297b6dea45
Headers show
Series [v2,1/3] ASoC: SOF: sof-audio: setup sched widgets during pipeline complete step | expand

Commit Message

Kai Vehmanen Nov. 23, 2021, 5:16 p.m. UTC 
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

It's not clear why we would walk the list backwards. That makes no
difference.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
---
 sound/soc/sof/topology.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Brown Nov. 23, 2021, 6:08 p.m. UTC | #1 
On Tue, Nov 23, 2021 at 07:16:05PM +0200, Kai Vehmanen wrote:
> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> 
> It's not clear why we would walk the list backwards. That makes no
> difference.

Cleanup patches like this should come after fixes rather than in the
middle of them to ensure that the fixes can be applied as such.
diff mbox series

Patch

diff --git a/sound/soc/sof/topology.c b/sound/soc/sof/topology.c
index 63948bb30710..b3ad3a604918 100644
--- a/sound/soc/sof/topology.c
+++ b/sound/soc/sof/topology.c
@@ -3529,7 +3529,7 @@  static int sof_complete(struct snd_soc_component *scomp)
 			 * Apply the dynamic_pipeline_widget flag and set the pipe_widget field
 			 * for all widgets that have the same pipeline ID as the scheduler widget
 			 */
-			list_for_each_entry_reverse(comp_swidget, &sdev->widget_list, list)
+			list_for_each_entry(comp_swidget, &sdev->widget_list, list)
 				if (comp_swidget->pipeline_id == swidget->pipeline_id) {
 					ret = sof_set_pipe_widget(sdev, swidget, comp_swidget);
 					if (ret < 0)