diff mbox series

[2/2] ASoC: convert Everest ES8156 binding to yaml

Message ID 20211210151041.108751-3-chenshumin86@sina.com (mailing list archive)
State New, archived
Headers show
Series This patches provide ASoc codec support for ES8156 | expand

Commit Message

Shumin Chen Dec. 10, 2021, 3:10 p.m. UTC
This patch converts Everest Semiconductor ES8156 low power audio
CODEC binding to DT schema.

Signed-off-by: Shumin Chen <chenshumin86@sina.com>
---
 .../bindings/sound/everest,es8156.yaml        | 49 +++++++++++++++++++
 1 file changed, 49 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/everest,es8156.yaml

Comments

Pierre-Louis Bossart Dec. 10, 2021, 4:29 p.m. UTC | #1
On 12/10/21 9:10 AM, Shumin Chen wrote:
> This patch converts Everest Semiconductor ES8156 low power audio
> CODEC binding to DT schema.

this doesn't really convert anything but *adds* properties for ES8156.

You're probably missing the device tree folks, added Rob + device tree
mailing list in CC:

> 
> Signed-off-by: Shumin Chen <chenshumin86@sina.com>
> ---
>  .../bindings/sound/everest,es8156.yaml        | 49 +++++++++++++++++++
>  1 file changed, 49 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/everest,es8156.yaml
> 
> diff --git a/Documentation/devicetree/bindings/sound/everest,es8156.yaml b/Documentation/devicetree/bindings/sound/everest,es8156.yaml
> new file mode 100644
> index 000000000000..695d542013c2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/everest,es8156.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/everest,es8156.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Everest ES8156 audio CODEC
> +
> +maintainers:
> +  - Shumin Chen <chenshumin86@sina.com>
> +
> +properties:
> +  compatible:
> +    const: everest,es8156
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    items:
> +      - description: clock for master clock (MCLK)
> +
> +  clock-names:
> +    items:
> +      - const: mclk
> +
> +  "#sound-dai-cells":
> +    const: 0
> +
> +required:
> +  - compatible
> +  - reg
> +  - "#sound-dai-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c0 {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +      es8156: codec@8 {
> +        compatible = "everest,es8156";
> +        reg = <0x11>;
> +        clocks = <&clks 10>;
> +        clock-names = "mclk";
> +        #sound-dai-cells = <0>;
> +      };
> +    };
>
Mark Brown Dec. 10, 2021, 4:47 p.m. UTC | #2
On Fri, Dec 10, 2021 at 11:10:41PM +0800, Shumin Chen wrote:

> +properties:
> +  compatible:
> +    const: everest,es8156
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    items:
> +      - description: clock for master clock (MCLK)

This was optional in the code but is mandatory in the binding.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/everest,es8156.yaml b/Documentation/devicetree/bindings/sound/everest,es8156.yaml
new file mode 100644
index 000000000000..695d542013c2
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/everest,es8156.yaml
@@ -0,0 +1,49 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/everest,es8156.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Everest ES8156 audio CODEC
+
+maintainers:
+  - Shumin Chen <chenshumin86@sina.com>
+
+properties:
+  compatible:
+    const: everest,es8156
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    items:
+      - description: clock for master clock (MCLK)
+
+  clock-names:
+    items:
+      - const: mclk
+
+  "#sound-dai-cells":
+    const: 0
+
+required:
+  - compatible
+  - reg
+  - "#sound-dai-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c0 {
+      #address-cells = <1>;
+      #size-cells = <0>;
+      es8156: codec@8 {
+        compatible = "everest,es8156";
+        reg = <0x11>;
+        clocks = <&clks 10>;
+        clock-names = "mclk";
+        #sound-dai-cells = <0>;
+      };
+    };