| Message ID | 20220105034103.12484-1-fbl718@163.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ALSA: hda/realtek: Add quirk for Legion Y9000X 2020 | expand |
On Wed, Jan 05, 2022 at 09:26:16AM +0100, Takashi Iwai wrote: > On Wed, 05 Jan 2022 04:41:01 +0100, > Baole Fang wrote: > > > > commit 25960cafa06e6fcd830e6c792e6a7de68c1e25ed upstream. > > I couldn't find this commit. Is this a bogus information? > > > Legion Y9000X 2020 has a speaker, but the speaker doesn't work. > > This can be fixed by applying alc285_fixup_ideapad_s740_coef > > to fix the speaker's coefficients. > > Besides, to support the transition between the speaker and the headphone, > > alc287_fixup_legion_15imhg05_speakers needs to be run. > > > > Signed-off-by: Baole Fang <fbl718@163.com> > > The code change itself looks fine, so I'd apply it if the line above > can be omitted. That commit id comes from 5.15.12, and it is the commit id of the release commit: 25960cafa06e ("Linux 5.15.12") which makes no sense at all. Baole, why did you add this line? confused, greg k-h
Sorry, this is my first time to submit patch to Linux, so I'm not quite familiar with the convention. Since I was changing based on v5.15.12 and I saw others mentioning their upstream commit, I included the that commit id. Please forgive me and tell me what is supposed to be done if possible. I still have a lot to learn. Best Regards, Baole Fang On 2022/1/5 下午6:55, Greg Kroah-Hartman wrote: > On Wed, Jan 05, 2022 at 09:26:16AM +0100, Takashi Iwai wrote: >> On Wed, 05 Jan 2022 04:41:01 +0100, >> Baole Fang wrote: >>> commit 25960cafa06e6fcd830e6c792e6a7de68c1e25ed upstream. >> I couldn't find this commit. Is this a bogus information? >> >>> Legion Y9000X 2020 has a speaker, but the speaker doesn't work. >>> This can be fixed by applying alc285_fixup_ideapad_s740_coef >>> to fix the speaker's coefficients. >>> Besides, to support the transition between the speaker and the headphone, >>> alc287_fixup_legion_15imhg05_speakers needs to be run. >>> >>> Signed-off-by: Baole Fang <fbl718@163.com> >> The code change itself looks fine, so I'd apply it if the line above >> can be omitted. > That commit id comes from 5.15.12, and it is the commit id of the > release commit: > 25960cafa06e ("Linux 5.15.12") > which makes no sense at all. > > Baole, why did you add this line? > > confused, > > greg k-h
On Wed, Jan 05, 2022 at 07:39:33PM +0800, Baole Fang wrote: > Sorry, this is my first time to submit patch to Linux, so I'm not quite > familiar with the convention. Since I was changing based on v5.15.12 and I > saw others mentioning their upstream commit, I included the that commit id. Those commits were coming from the stable backports only, they were not done by the original author. > Please forgive me and tell me what is supposed to be done if possible. I > still have a lot to learn. Please take a look at the "first kernel patch" tutorial on the kernelnewbies.org site for a good example of how to do all of this. Also the Documentation/SubmittingPatches file in the kernel source tree should help out. thanks, greg k-h
Thank you for your explanation! I shouldn't have written that line and I supposed it can be ignored. Is there anything else I could do? Best Regards, Baole Fang On 2022/1/5 下午7:44, Greg Kroah-Hartman wrote: > On Wed, Jan 05, 2022 at 07:39:33PM +0800, Baole Fang wrote: >> Sorry, this is my first time to submit patch to Linux, so I'm not quite >> familiar with the convention. Since I was changing based on v5.15.12 and I >> saw others mentioning their upstream commit, I included the that commit id. > Those commits were coming from the stable backports only, they were not > done by the original author. > >> Please forgive me and tell me what is supposed to be done if possible. I >> still have a lot to learn. > Please take a look at the "first kernel patch" tutorial on the > kernelnewbies.org site for a good example of how to do all of this. > > Also the Documentation/SubmittingPatches file in the kernel source tree > should help out. > > thanks, > > greg k-h
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Wed, Jan 05, 2022 at 08:29:26PM +0800, Baole Fang wrote: > Thank you for your explanation! I shouldn't have written that line and I > supposed it can be ignored. Is there anything else I could do? We can not just "ignore" it, you need to fix your change up and resend it in a proper format so that it can be applied. As-is, it is not acceptable, sorry. thanks, greg k-h
On 2022/1/5 下午8:33, Greg Kroah-Hartman wrote: > We can not just "ignore" it, you need to fix your change up and resend > it in a proper format so that it can be applied. > > As-is, it is not acceptable, sorry. Thank you, I'm going to resend the patch. Best Regards, Baole Fang
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 28255e752c4a..c7232f9be690 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -6784,6 +6784,8 @@ enum { ALC256_FIXUP_SYSTEM76_MIC_NO_PRESENCE, ALC233_FIXUP_NO_AUDIO_JACK, ALC256_FIXUP_MIC_NO_PRESENCE_AND_RESUME, + ALC285_FIXUP_LEGION_Y9000X_SPEAKERS, + ALC285_FIXUP_LEGION_Y9000X_AUTOMUTE, }; static const struct hda_fixup alc269_fixups[] = { @@ -8380,6 +8382,18 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF, }, + [ALC285_FIXUP_LEGION_Y9000X_SPEAKERS] = { + .type = HDA_FIXUP_FUNC, + .v.func = alc285_fixup_ideapad_s740_coef, + .chained = true, + .chain_id = ALC285_FIXUP_LEGION_Y9000X_AUTOMUTE, + }, + [ALC285_FIXUP_LEGION_Y9000X_AUTOMUTE] = { + .type = HDA_FIXUP_FUNC, + .v.func = alc287_fixup_legion_15imhg05_speakers, + .chained = true, + .chain_id = ALC269_FIXUP_THINKPAD_ACPI, + }, [ALC287_FIXUP_LEGION_15IMHG05_SPEAKERS] = { .type = HDA_FIXUP_VERBS, //.v.verbs = legion_15imhg05_coefs, @@ -8923,6 +8937,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x17aa, 0x31af, "ThinkCentre Station", ALC623_FIXUP_LENOVO_THINKSTATION_P340), SND_PCI_QUIRK(0x17aa, 0x3818, "Lenovo C940", ALC298_FIXUP_LENOVO_SPK_VOLUME), SND_PCI_QUIRK(0x17aa, 0x3827, "Ideapad S740", ALC285_FIXUP_IDEAPAD_S740_COEF), + SND_PCI_QUIRK(0x17aa, 0x3824, "Legion Y9000X 2020", ALC285_FIXUP_LEGION_Y9000X_SPEAKERS), SND_PCI_QUIRK(0x17aa, 0x3843, "Yoga 9i", ALC287_FIXUP_IDEAPAD_BASS_SPK_AMP), SND_PCI_QUIRK(0x17aa, 0x3813, "Legion 7i 15IMHG05", ALC287_FIXUP_LEGION_15IMHG05_SPEAKERS), SND_PCI_QUIRK(0x17aa, 0x3852, "Lenovo Yoga 7 14ITL5", ALC287_FIXUP_YOGA7_14ITL_SPEAKERS),
commit 25960cafa06e6fcd830e6c792e6a7de68c1e25ed upstream. Legion Y9000X 2020 has a speaker, but the speaker doesn't work. This can be fixed by applying alc285_fixup_ideapad_s740_coef to fix the speaker's coefficients. Besides, to support the transition between the speaker and the headphone, alc287_fixup_legion_15imhg05_speakers needs to be run. Signed-off-by: Baole Fang <fbl718@163.com> --- sound/pci/hda/patch_realtek.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+)