| Message ID | 20220107020851.3095591-1-jiasheng@iscas.ac.cn (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1b1f98dd70dcfd25476adabcbe72484312e879f7 |
| Headers | show |
| Series | [v3] ALSA: intel_hdmi: Check for error num after setting mask | expand |
On Fri, 07 Jan 2022 03:08:51 +0100, Jiasheng Jiang wrote: > > To maintain the consistency of the code, it should be better to add the > sanity check after calling dma_set_mask_and_coherent(), like > tegra_pcm_dma_allocate() in `sound/soc/tegra/tegra_pcm.c`. > > Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> Thanks, applied now. Takashi
diff --git a/sound/x86/intel_hdmi_audio.c b/sound/x86/intel_hdmi_audio.c index 378826312abe..1c94eaff1931 100644 --- a/sound/x86/intel_hdmi_audio.c +++ b/sound/x86/intel_hdmi_audio.c @@ -1750,7 +1750,9 @@ static int hdmi_lpe_audio_probe(struct platform_device *pdev) card_ctx->irq = irq; /* only 32bit addressable */ - dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); + ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); + if (ret) + return ret; init_channel_allocations();
To maintain the consistency of the code, it should be better to add the sanity check after calling dma_set_mask_and_coherent(), like tegra_pcm_dma_allocate() in `sound/soc/tegra/tegra_pcm.c`. Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> --- Changelog v2 -> v3 * Change 1. Remove the fixes tag and change the message. * Change 2. Correct the patch to fit the lastest code. --- sound/x86/intel_hdmi_audio.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)