From patchwork Tue Jan 11 19:05:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Amadeusz_S=C5=82awi=C5=84ski?= X-Patchwork-Id: 12709700 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F30BC433F5 for ; Tue, 11 Jan 2022 11:07:48 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 72A991926; Tue, 11 Jan 2022 12:06:56 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 72A991926 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1641899266; bh=S84M8gP6Qre+XJE1k923GHKDAiyY37wNBkvrflzp1T8=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=kPXIoslRccquIGnbJVO6tcYCuRzVbonWdyWh99LGHh5Tzed2TjKEISHI3VqOZGJgH QAF5QiyvqxS0UHxtsUcs55V/sGEq1k8kibYE5EpO89I6AO9GReBdGGAYKNmPuxRNlj wdSDsq8anJOJHbRO4FzSOwQdUG4tgN/CHBaHvobc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 36FA8F804FE; Tue, 11 Jan 2022 12:06:12 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C3D7EF804AB; Tue, 11 Jan 2022 12:06:08 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 296BFF80302 for ; Tue, 11 Jan 2022 12:06:01 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 296BFF80302 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="CV5NCR/S" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641899163; x=1673435163; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=S84M8gP6Qre+XJE1k923GHKDAiyY37wNBkvrflzp1T8=; b=CV5NCR/SURuvmUJaQxLL3NImXBe2IoCkpz8vY2ssOT6eOVdb08gPd/Zf EUIRdagOXlA80awlXAOIYn6RWcLtIYMQsedRPKyJRdXv33CxHEbarGmce CGDwohf5HtP4pMOmv/NM9K6szBq1A4K5QQhqlfkIgAXZV0Ov4dM9diI59 Wxx5Xc3L057PM4F/ej/vMJ8hTVnAeJevOpo2RBqZju6jvC1dhagC4Na2a BXyucJXDbL4CPvCEL99dE8XvwdcguYl8g524m1e7aFqShdaJZE8H9t3a9 qiepmnYQ0SFWnS2wIFUWznA4ciurH3majTMF2Iv8v9O7cVbd/ptk8HNqM g==; X-IronPort-AV: E=McAfee;i="6200,9189,10223"; a="241012615" X-IronPort-AV: E=Sophos;i="5.88,279,1635231600"; d="scan'208";a="241012615" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2022 03:05:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,279,1635231600"; d="scan'208";a="528700949" Received: from dev2 (HELO DEV2.igk.intel.com) ([10.237.148.94]) by orsmga008.jf.intel.com with ESMTP; 11 Jan 2022 03:05:57 -0800 From: =?utf-8?q?Amadeusz_S=C5=82awi=C5=84ski?= To: Liam Girdwood , Mark Brown , Takashi Iwai Subject: [PATCH 2/3] ASoC: topology: Allow TLV control to be either read or write Date: Tue, 11 Jan 2022 20:05:27 +0100 Message-Id: <20220111190528.445248-3-amadeuszx.slawinski@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220111190528.445248-1-amadeuszx.slawinski@linux.intel.com> References: <20220111190528.445248-1-amadeuszx.slawinski@linux.intel.com> MIME-Version: 1.0 Cc: Cezary Rojewski , =?utf-8?q?Amadeusz_S=C5=82a?= =?utf-8?q?wi=C5=84ski?= , Pierre-Louis Bossart , alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" There is no reason to force readwrite access on TLV controls. It can be either read, write or both. This is further evidenced in code where it performs following checks: if ((k->access & SNDRV_CTL_ELEM_ACCESS_TLV_READ) && !sbe->get) return -EINVAL; if ((k->access & SNDRV_CTL_ELEM_ACCESS_TLV_WRITE) && !sbe->put) return -EINVAL; Signed-off-by: Amadeusz Sławiński Reviewed-by: Cezary Rojewski --- sound/soc/soc-topology.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/soc-topology.c b/sound/soc/soc-topology.c index e0f72ddd72c1..9d24184f85f9 100644 --- a/sound/soc/soc-topology.c +++ b/sound/soc/soc-topology.c @@ -512,7 +512,8 @@ static int soc_tplg_kcontrol_bind_io(struct snd_soc_tplg_ctl_hdr *hdr, if (le32_to_cpu(hdr->ops.info) == SND_SOC_TPLG_CTL_BYTES && k->iface & SNDRV_CTL_ELEM_IFACE_MIXER - && k->access & SNDRV_CTL_ELEM_ACCESS_TLV_READWRITE + && (k->access & SNDRV_CTL_ELEM_ACCESS_TLV_READ + || k->access & SNDRV_CTL_ELEM_ACCESS_TLV_WRITE) && k->access & SNDRV_CTL_ELEM_ACCESS_TLV_CALLBACK) { struct soc_bytes_ext *sbe; struct snd_soc_tplg_bytes_control *be;