From patchwork Wed Jan 12 17:00:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Amadeusz_S=C5=82awi=C5=84ski?= X-Patchwork-Id: 12711061 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39294C433F5 for ; Wed, 12 Jan 2022 09:02:27 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3FA8E195A; Wed, 12 Jan 2022 10:01:35 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3FA8E195A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1641978145; bh=+LNZHxxl5hhVgyY0XAKkh0uPwdUOs8jU5euZhrYD8Z0=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=pmrh7QYsB4BPPxXkJLJ6DWKi25KIM+wK6EjyyVcC0b8RMpx7PrVAsmqBq7M/YThTg 8G4OSQfV0YUqgsGNiwGtwuNrj4VV4x8RN8JYAmlrZLcon57YyWk65M6e3rMDlJkwfh ZVI+3Z6w3tA/3B6dmONYOBfvCaTU4LlI8u4q/VQ4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 45AD9F804FB; Wed, 12 Jan 2022 10:00:49 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 97267F80054; Wed, 12 Jan 2022 10:00:47 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A4764F8026A for ; Wed, 12 Jan 2022 10:00:41 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A4764F8026A Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ReGeui0R" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641978042; x=1673514042; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=+LNZHxxl5hhVgyY0XAKkh0uPwdUOs8jU5euZhrYD8Z0=; b=ReGeui0RP6H1ECTbNrtHfIb2XZyoGxQhZ1Hbfo7TGV0M8W2El39YcS4x 2t841NSDNsGLOuWs1xOmwjSTMwW5qyOB6D5GBSKx0F6o/M7faonyJRJrU +uKWJp4sgFJHGF9W4Wonjf7IohZ/XO8ZF1VA5pkCOap00cILwhi3umnIw egK3CsZITLtBY5WSE+Ef3kJDusP17aFXXNFUQEwrvA6YrN6OOTRuAY/sZ rCER+/yzhQivyMApKKzDeEqBrbnlTAoD8N61Z+0UNSZXfyCikyMgnkfz+ GuVGhbXkegKv/Cs2mSAfD7IyRV50Nx+6/o8oM9JNxTuzz7kZ+ZyJ4ipRv A==; X-IronPort-AV: E=McAfee;i="6200,9189,10224"; a="223674382" X-IronPort-AV: E=Sophos;i="5.88,282,1635231600"; d="scan'208";a="223674382" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2022 01:00:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,282,1635231600"; d="scan'208";a="691318378" Received: from dev2.igk.intel.com ([10.237.148.94]) by orsmga005.jf.intel.com with ESMTP; 12 Jan 2022 01:00:39 -0800 From: =?utf-8?q?Amadeusz_S=C5=82awi=C5=84ski?= To: Liam Girdwood , Mark Brown , Takashi Iwai Subject: [PATCH v2 2/3] ASoC: topology: Allow TLV control to be either read or write Date: Wed, 12 Jan 2022 18:00:29 +0100 Message-Id: <20220112170030.569712-3-amadeuszx.slawinski@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220112170030.569712-1-amadeuszx.slawinski@linux.intel.com> References: <20220112170030.569712-1-amadeuszx.slawinski@linux.intel.com> MIME-Version: 1.0 Cc: Cezary Rojewski , =?utf-8?q?Amadeusz_S=C5=82a?= =?utf-8?q?wi=C5=84ski?= , Pierre-Louis Bossart , alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" There is no reason to force readwrite access on TLV controls. It can be either read, write or both. This is further evidenced in code where it performs following checks: if ((k->access & SNDRV_CTL_ELEM_ACCESS_TLV_READ) && !sbe->get) return -EINVAL; if ((k->access & SNDRV_CTL_ELEM_ACCESS_TLV_WRITE) && !sbe->put) return -EINVAL; Fixes: 1a3232d2f61d ("ASoC: topology: Add support for TLV bytes controls") Signed-off-by: Amadeusz Sławiński Reviewed-by: Cezary Rojewski Reviewed-by: Pierre-Louis Bossart --- sound/soc/soc-topology.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/soc-topology.c b/sound/soc/soc-topology.c index e0f72ddd72c1..9d24184f85f9 100644 --- a/sound/soc/soc-topology.c +++ b/sound/soc/soc-topology.c @@ -512,7 +512,8 @@ static int soc_tplg_kcontrol_bind_io(struct snd_soc_tplg_ctl_hdr *hdr, if (le32_to_cpu(hdr->ops.info) == SND_SOC_TPLG_CTL_BYTES && k->iface & SNDRV_CTL_ELEM_IFACE_MIXER - && k->access & SNDRV_CTL_ELEM_ACCESS_TLV_READWRITE + && (k->access & SNDRV_CTL_ELEM_ACCESS_TLV_READ + || k->access & SNDRV_CTL_ELEM_ACCESS_TLV_WRITE) && k->access & SNDRV_CTL_ELEM_ACCESS_TLV_CALLBACK) { struct soc_bytes_ext *sbe; struct snd_soc_tplg_bytes_control *be;