Message ID | 20220201112144.29411-1-peter.ujfalusi@linux.intel.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | ALSA: hda: Skip codec shutdown in case the codec is not registered | expand |
On Tue, 01 Feb 2022 12:21:44 +0100, Peter Ujfalusi wrote: > > If the codec->registered is not set then it means that pm_runtime is > not yet enabled and the codec->pcm_list_head has not been initialized. > > The access to the not initialized pcm_list_head will lead a kernel crash > during shutdown. > > Reported-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com> > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com> > Tested-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com> Thanks, applied now. Takashi
diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c index 7016b48227bf..f552785d301e 100644 --- a/sound/pci/hda/hda_codec.c +++ b/sound/pci/hda/hda_codec.c @@ -3000,6 +3000,10 @@ void snd_hda_codec_shutdown(struct hda_codec *codec) { struct hda_pcm *cpcm; + /* Skip the shutdown if codec is not registered */ + if (!codec->registered) + return; + list_for_each_entry(cpcm, &codec->pcm_list_head, list) snd_pcm_suspend_all(cpcm->pcm);