| Message ID | 20220224172324.17976-1-peter.ujfalusi@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 299905881ebd3b7ee5e3525356529c3d0ceb0688 |
| Headers | show |
| Series | ASoC: SOF: Declare sof_compress_ops in sof-priv.h | expand |
On Thu, 24 Feb 2022 19:23:24 +0200, Peter Ujfalusi wrote: > Fix the following sparse error: > sound/soc/sof/compress.c:310:25: error: symbol 'sof_compressed_ops' was not declared. Should it be static? > > Do not enable set the pd->compress_ops yet as it is not a valid assumption > that real compress support really works when CONFIG_SND_SOC_SOF_COMPRESS > is set as the HDA Probes support also selects it, but compressed audio > is not supported (yet) on Intel platforms. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: SOF: Declare sof_compress_ops in sof-priv.h commit: 299905881ebd3b7ee5e3525356529c3d0ceb0688 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/sof/sof-priv.h b/sound/soc/sof/sof-priv.h index 2c8e556cd5cc..2e19ac619ad5 100644 --- a/sound/soc/sof/sof-priv.h +++ b/sound/soc/sof/sof-priv.h @@ -497,6 +497,11 @@ void snd_sof_complete(struct device *dev); void snd_sof_new_platform_drv(struct snd_sof_dev *sdev); +/* + * Compress support + */ +extern struct snd_compress_ops sof_compressed_ops; + /* * Firmware loading. */
Fix the following sparse error: sound/soc/sof/compress.c:310:25: error: symbol 'sof_compressed_ops' was not declared. Should it be static? Do not enable set the pd->compress_ops yet as it is not a valid assumption that real compress support really works when CONFIG_SND_SOC_SOF_COMPRESS is set as the HDA Probes support also selects it, but compressed audio is not supported (yet) on Intel platforms. Fixes: 6324cf901e14c ("ASoC: SOF: compr: Add compress ops implementation") Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com> --- sound/soc/sof/sof-priv.h | 5 +++++ 1 file changed, 5 insertions(+)