| Message ID | 20220304131449.GC28739@kili (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 899a9a7f624b5a9d100c9ac6b3f0960981f0e4c5 |
| Headers | show |
| Series | [1/3] ASoC: amd: acp: Fix signedness bug in renoir_audio_probe() | expand |
On Fri, 4 Mar 2022 16:14:49 +0300, Dan Carpenter wrote: > The "adata->i2s_irq" is unsigned so this error handling will not > work. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/3] ASoC: amd: acp: Fix signedness bug in renoir_audio_probe() commit: 899a9a7f624b5a9d100c9ac6b3f0960981f0e4c5 [2/4] ASoC: amd: pcm-dma: Fix signedness bug in acp_pdm_audio_probe() commit: 00925272f166db31fed73f3c00c151eb5f7ce1d8 [4/4] ASoC: amd: pcm-dma: Fix signedness bug in acp3x_audio_probe() commit: 9a33f5632ca573e512c49fa46cc7131cbc83d4c9 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/amd/acp/acp-renoir.c b/sound/soc/amd/acp/acp-renoir.c index 738cf2e2b973..75c9229ece97 100644 --- a/sound/soc/amd/acp/acp-renoir.c +++ b/sound/soc/amd/acp/acp-renoir.c @@ -282,9 +282,10 @@ static int renoir_audio_probe(struct platform_device *pdev) if (!adata->acp_base) return -ENOMEM; - adata->i2s_irq = platform_get_irq_byname(pdev, "acp_dai_irq"); - if (adata->i2s_irq < 0) - return -ENODEV; + ret = platform_get_irq_byname(pdev, "acp_dai_irq"); + if (ret < 0) + return ret; + adata->i2s_irq = ret; adata->dev = dev; adata->dai_driver = acp_renoir_dai;
The "adata->i2s_irq" is unsigned so this error handling will not work. Fixes: 3304a242f45a ("ASoC: amd: Use platform_get_irq_byname() to get the interrupt") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- sound/soc/amd/acp/acp-renoir.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)