| Message ID | 20220305123519.26788-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] ASoC: amd: acp: signedness bug in acp-renoir | expand |
This error handling already fixed by Dan here https://patchwork.kernel.org/project/alsa-devel/patch/20220304131449.GC28739@kili/ On 3/5/2022 6:05 PM, YueHaibing wrote: > [CAUTION: External Email] > > In renoir_audio_probe() platform_get_irq_byname() may return error, > but i2s_irq now is unsigned int so the error handling is never triggered. > > Fixes: 3304a242f45a ("ASoC: amd: Use platform_get_irq_byname() to get the interrupt") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > sound/soc/amd/acp/amd.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/amd/acp/amd.h b/sound/soc/amd/acp/amd.h > index 8fd38bf4d3bd..acb50d9fca58 100644 > --- a/sound/soc/amd/acp/amd.h > +++ b/sound/soc/amd/acp/amd.h > @@ -96,7 +96,7 @@ struct acp_dev_data { > char *name; > struct device *dev; > void __iomem *acp_base; > - unsigned int i2s_irq; > + int i2s_irq; > > /* SOC specific dais */ > struct snd_soc_dai_driver *dai_driver; > -- > 2.17.1 >
diff --git a/sound/soc/amd/acp/amd.h b/sound/soc/amd/acp/amd.h index 8fd38bf4d3bd..acb50d9fca58 100644 --- a/sound/soc/amd/acp/amd.h +++ b/sound/soc/amd/acp/amd.h @@ -96,7 +96,7 @@ struct acp_dev_data { char *name; struct device *dev; void __iomem *acp_base; - unsigned int i2s_irq; + int i2s_irq; /* SOC specific dais */ struct snd_soc_dai_driver *dai_driver;
In renoir_audio_probe() platform_get_irq_byname() may return error, but i2s_irq now is unsigned int so the error handling is never triggered. Fixes: 3304a242f45a ("ASoC: amd: Use platform_get_irq_byname() to get the interrupt") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- sound/soc/amd/acp/amd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)