| Message ID | 20220317221134.566358-1-kai.heng.feng@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 864cb14c0fa22344613ae93d68e155bf9bbbc9fb |
| Headers | show |
| Series | ALSA: hda/realtek: Fix LED on Zbook Studio G9 | expand |
On Thu, 17 Mar 2022 23:11:33 +0100, Kai-Heng Feng wrote: > > Commit 07bcab93946c ("ALSA: hda/realtek: Add support for HP Laptops") > breaks mute and micmute LEDs because it changed the LED quirk from > ALC285_FIXUP_HP_GPIO_LED to ALC245_FIXUP_HP_GPIO_LED, so change it back > here. > > Also reorder the chain of quirks to ensure LED quirk is the last one > being applied. > > Fixes: 07bcab93946c ("ALSA: hda/realtek: Add support for HP Laptops") > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> Thanks, applied now. Takashi
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 4650ef9110d62..1d14be4ee31d8 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -8773,9 +8773,9 @@ static const struct hda_fixup alc269_fixups[] = { }, [ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED] = { .type = HDA_FIXUP_FUNC, - .v.func = alc245_fixup_hp_gpio_led, + .v.func = cs35l41_fixup_spi_four, .chained = true, - .chain_id = ALC245_FIXUP_CS35L41_SPI_4, + .chain_id = ALC285_FIXUP_HP_GPIO_LED, }, [ALC285_FIXUP_HP_SPEAKERS_MICMUTE_LED] = { .type = HDA_FIXUP_VERBS,
Commit 07bcab93946c ("ALSA: hda/realtek: Add support for HP Laptops") breaks mute and micmute LEDs because it changed the LED quirk from ALC285_FIXUP_HP_GPIO_LED to ALC245_FIXUP_HP_GPIO_LED, so change it back here. Also reorder the chain of quirks to ensure LED quirk is the last one being applied. Fixes: 07bcab93946c ("ALSA: hda/realtek: Add support for HP Laptops") Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> --- sound/pci/hda/patch_realtek.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)