From patchwork Thu Mar 17 22:11:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kai-Heng Feng X-Patchwork-Id: 12784621 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED787C433F5 for ; Thu, 17 Mar 2022 22:13:30 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3D7551932; Thu, 17 Mar 2022 23:12:38 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3D7551932 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1647555208; bh=I2rOlZBp/Y8YpX+WD2ONJtu7x0j9d3GByjrH/JwyxQU=; h=From:To:Subject:Date:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=OjJVq0gYdILYm/201PZsSk/tkPWVzUl4PlPd4lkhqvdgCLjZ/MP4VirYNctkioojf W2AS3+5v1L29q+SnjPLXzzRvgQs/PVJD7wuUcP7iu+sqkfYD4yMsj8m0jq3xym88FA K5FFRtho0lSGOSKWP0ndozjiKGqf5Gw0tCr873Qw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B0339F80087; Thu, 17 Mar 2022 23:12:37 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D83F9F8013F; Thu, 17 Mar 2022 23:12:35 +0100 (CET) Received: from smtp-relay-canonical-1.canonical.com (smtp-relay-canonical-1.canonical.com [185.125.188.121]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A7620F80087 for ; Thu, 17 Mar 2022 23:12:29 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A7620F80087 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=canonical.com header.i=@canonical.com header.b="JScbuvNg" Received: from localhost.localdomain (unknown [10.101.196.174]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id 7191141922; Thu, 17 Mar 2022 22:12:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1647555144; bh=GSGY9xvV7/cHW9kKHfcQPWbJ+8pjDmIgHHQ0jRgjQco=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=JScbuvNgfJZNPo1B66r4RAkRLKVBcNqKt8K4fDEm256jiBV082ldnIN/HDpvk2GIV N7O3WsfUQcAVJ7jJwWA975ldgqNiVzKcAeErTDsZEstxTSlhct9YAH/PW/daDLrqMo vGkcqHXLdcCo47/L+tqPFYIWinaIGxEVLmYN/vbIi8i3qikGyAyLo9wkLWZdFaWSia 6F9xztHCbQJexrIDqWJhWeoFV/7V0a1ThciivQDsLCRI+F0psxRvpyJdfLygp+iUSq Rs5V+lutFWF8KMwavhUCsR9zO6WIVAOayqVUwomxFsleeIRQ8IbCU9rLtoxmNa1WZ9 lErm8GMbgnLKg== From: Kai-Heng Feng To: tiwai@suse.com Subject: [PATCH] ALSA: hda/realtek: Fix LED on Zbook Studio G9 Date: Fri, 18 Mar 2022 06:11:33 +0800 Message-Id: <20220317221134.566358-1-kai.heng.feng@canonical.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Cc: Stefan Binding , Kailang Yang , Lucas Tanure , Jeremy Szu , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Werner Sembach , Hui Wang , Hans de Goede , Kai-Heng Feng , Sami Loone , Cameron Berkenpas X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Commit 07bcab93946c ("ALSA: hda/realtek: Add support for HP Laptops") breaks mute and micmute LEDs because it changed the LED quirk from ALC285_FIXUP_HP_GPIO_LED to ALC245_FIXUP_HP_GPIO_LED, so change it back here. Also reorder the chain of quirks to ensure LED quirk is the last one being applied. Fixes: 07bcab93946c ("ALSA: hda/realtek: Add support for HP Laptops") Signed-off-by: Kai-Heng Feng --- sound/pci/hda/patch_realtek.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 4650ef9110d62..1d14be4ee31d8 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -8773,9 +8773,9 @@ static const struct hda_fixup alc269_fixups[] = { }, [ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED] = { .type = HDA_FIXUP_FUNC, - .v.func = alc245_fixup_hp_gpio_led, + .v.func = cs35l41_fixup_spi_four, .chained = true, - .chain_id = ALC245_FIXUP_CS35L41_SPI_4, + .chain_id = ALC285_FIXUP_HP_GPIO_LED, }, [ALC285_FIXUP_HP_SPEAKERS_MICMUTE_LED] = { .type = HDA_FIXUP_VERBS,