diff mbox series

[v3,18/20] ASoC: fsl_micfil: drop only once used defines

Message ID 20220405075959.2744803-19-s.hauer@pengutronix.de (mailing list archive)
State Superseded
Headers show
Series ASoC: fsl_micfil: Driver updates | expand

Commit Message

Sascha Hauer April 5, 2022, 7:59 a.m. UTC
FSL_MICFIL_RATES and FSL_MICFIL_FORMATS is only used once. Drop
the unnecesary indirection and use SNDRV_PCM_RATE_8000_48000 and
SNDRV_PCM_FMTBIT_S16_LE directly.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 sound/soc/fsl/fsl_micfil.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

Comments

Shengjiu Wang April 7, 2022, 5:27 a.m. UTC | #1
On Tue, Apr 5, 2022 at 4:00 PM Sascha Hauer <s.hauer@pengutronix.de> wrote:

> FSL_MICFIL_RATES and FSL_MICFIL_FORMATS is only used once. Drop
> the unnecesary indirection and use SNDRV_PCM_RATE_8000_48000 and
> SNDRV_PCM_FMTBIT_S16_LE directly.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
>

Acked-by: Shengjiu Wang <shengjiu.wang@gmail.com>

Best regards
Wang Shengjiu


> ---
>  sound/soc/fsl/fsl_micfil.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fsl_micfil.c
> index f7742a6e6c204..f536ea2db89db 100644
> --- a/sound/soc/fsl/fsl_micfil.c
> +++ b/sound/soc/fsl/fsl_micfil.c
> @@ -25,9 +25,6 @@
>
>  #include "fsl_micfil.h"
>
> -#define FSL_MICFIL_RATES               SNDRV_PCM_RATE_8000_48000
> -#define FSL_MICFIL_FORMATS             (SNDRV_PCM_FMTBIT_S16_LE)
> -
>  #define MICFIL_OSR_DEFAULT     16
>
>  enum quality {
> @@ -349,8 +346,8 @@ static struct snd_soc_dai_driver fsl_micfil_dai = {
>                 .stream_name = "CPU-Capture",
>                 .channels_min = 1,
>                 .channels_max = 8,
> -               .rates = FSL_MICFIL_RATES,
> -               .formats = FSL_MICFIL_FORMATS,
> +               .rates = SNDRV_PCM_RATE_8000_48000,
> +               .formats = SNDRV_PCM_FMTBIT_S16_LE,
>         },
>         .ops = &fsl_micfil_dai_ops,
>  };
> --
> 2.30.2
>
>
diff mbox series

Patch

diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fsl_micfil.c
index f7742a6e6c204..f536ea2db89db 100644
--- a/sound/soc/fsl/fsl_micfil.c
+++ b/sound/soc/fsl/fsl_micfil.c
@@ -25,9 +25,6 @@ 
 
 #include "fsl_micfil.h"
 
-#define FSL_MICFIL_RATES		SNDRV_PCM_RATE_8000_48000
-#define FSL_MICFIL_FORMATS		(SNDRV_PCM_FMTBIT_S16_LE)
-
 #define MICFIL_OSR_DEFAULT	16
 
 enum quality {
@@ -349,8 +346,8 @@  static struct snd_soc_dai_driver fsl_micfil_dai = {
 		.stream_name = "CPU-Capture",
 		.channels_min = 1,
 		.channels_max = 8,
-		.rates = FSL_MICFIL_RATES,
-		.formats = FSL_MICFIL_FORMATS,
+		.rates = SNDRV_PCM_RATE_8000_48000,
+		.formats = SNDRV_PCM_FMTBIT_S16_LE,
 	},
 	.ops = &fsl_micfil_dai_ops,
 };