| Message ID | 20220407084936.223075-22-s.hauer@pengutronix.de (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ASoC: fsl_micfil: Driver updates | expand |
On Thu, Apr 7, 2022 at 4:49 PM Sascha Hauer <s.hauer@pengutronix.de> wrote: > The micfil driver prints out the IRQ numbers for each interrupt at error > level. This information is useful for debugging at best, remove it. > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > --- > > Notes: > Changes since v3: > - new patch > > sound/soc/fsl/fsl_micfil.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fsl_micfil.c > index 8f0ab61fd1b07..be669523a4bf7 100644 > --- a/sound/soc/fsl/fsl_micfil.c > +++ b/sound/soc/fsl/fsl_micfil.c > @@ -597,7 +597,6 @@ static int fsl_micfil_probe(struct platform_device > *pdev) > /* get IRQs */ > for (i = 0; i < MICFIL_IRQ_LINES; i++) { > micfil->irq[i] = platform_get_irq(pdev, i); > - dev_err(&pdev->dev, "GET IRQ: %d\n", micfil->irq[i]); > dev_err to dev_dbg, is it better? > if (micfil->irq[i] < 0) > return micfil->irq[i]; > } > -- > 2.30.2 > >
On Fri, Apr 08, 2022 at 01:21:41PM +0800, Shengjiu Wang wrote: > On Thu, Apr 7, 2022 at 4:49 PM Sascha Hauer <[1]s.hauer@pengutronix.de> > wrote: > > The micfil driver prints out the IRQ numbers for each interrupt at error > level. This information is useful for debugging at best, remove it. > > Signed-off-by: Sascha Hauer <[2]s.hauer@pengutronix.de> > --- > > Notes: > Changes since v3: > - new patch > > sound/soc/fsl/fsl_micfil.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fsl_micfil.c > index 8f0ab61fd1b07..be669523a4bf7 100644 > --- a/sound/soc/fsl/fsl_micfil.c > +++ b/sound/soc/fsl/fsl_micfil.c > @@ -597,7 +597,6 @@ static int fsl_micfil_probe(struct platform_device > *pdev) > /* get IRQs */ > for (i = 0; i < MICFIL_IRQ_LINES; i++) { > micfil->irq[i] = platform_get_irq(pdev, i); > - dev_err(&pdev->dev, "GET IRQ: %d\n", micfil->irq[i]); > > dev_err to dev_dbg, is it better? I don't think so. You can see the interrupts in /proc/interrupts and currently the interrupts are not even used in the driver. Sascha
On Thu, Apr 7, 2022 at 4:49 PM Sascha Hauer <s.hauer@pengutronix.de> wrote: > The micfil driver prints out the IRQ numbers for each interrupt at error > level. This information is useful for debugging at best, remove it. > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > Acked-by: Shengjiu Wang <shengjiu.wang@gmail.com> best regards wang shengjiu > --- > > Notes: > Changes since v3: > - new patch > > sound/soc/fsl/fsl_micfil.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fsl_micfil.c > index 8f0ab61fd1b07..be669523a4bf7 100644 > --- a/sound/soc/fsl/fsl_micfil.c > +++ b/sound/soc/fsl/fsl_micfil.c > @@ -597,7 +597,6 @@ static int fsl_micfil_probe(struct platform_device > *pdev) > /* get IRQs */ > for (i = 0; i < MICFIL_IRQ_LINES; i++) { > micfil->irq[i] = platform_get_irq(pdev, i); > - dev_err(&pdev->dev, "GET IRQ: %d\n", micfil->irq[i]); > if (micfil->irq[i] < 0) > return micfil->irq[i]; > } > -- > 2.30.2 > >
diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fsl_micfil.c index 8f0ab61fd1b07..be669523a4bf7 100644 --- a/sound/soc/fsl/fsl_micfil.c +++ b/sound/soc/fsl/fsl_micfil.c @@ -597,7 +597,6 @@ static int fsl_micfil_probe(struct platform_device *pdev) /* get IRQs */ for (i = 0; i < MICFIL_IRQ_LINES; i++) { micfil->irq[i] = platform_get_irq(pdev, i); - dev_err(&pdev->dev, "GET IRQ: %d\n", micfil->irq[i]); if (micfil->irq[i] < 0) return micfil->irq[i]; }
The micfil driver prints out the IRQ numbers for each interrupt at error level. This information is useful for debugging at best, remove it. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> --- Notes: Changes since v3: - new patch sound/soc/fsl/fsl_micfil.c | 1 - 1 file changed, 1 deletion(-)