| Message ID | 20220411020908.580-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | dc7680ca7ac6c32b8c18aff36bca728a2f83e2a0 |
| Headers | show |
| Series | [-next] ASoC: tegra186_asrc: mark runtime-pm functions as __maybe_unused | expand |
On 11-04-2022 07:39, YueHaibing wrote: > sound/soc/tegra/tegra186_asrc.c:90:12: error: ‘tegra186_asrc_runtime_resume’ defined but not used [-Werror=unused-function] > static int tegra186_asrc_runtime_resume(struct device *dev) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > sound/soc/tegra/tegra186_asrc.c:80:12: error: ‘tegra186_asrc_runtime_suspend’ defined but not used [-Werror=unused-function] > static int tegra186_asrc_runtime_suspend(struct device *dev) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Mark these functions as __maybe_unused to avoid this kind of warning. > > Fixes: a2df8c2d5b36 ("ASoC: tegra: Add Tegra186 based ASRC driver") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > sound/soc/tegra/tegra186_asrc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Thanks for the patch. Reviewed-by: Sameer Pujar <spujar@nvidia.com>
On Mon, 11 Apr 2022 10:09:08 +0800, YueHaibing wrote: > sound/soc/tegra/tegra186_asrc.c:90:12: error: ‘tegra186_asrc_runtime_resume’ defined but not used [-Werror=unused-function] > static int tegra186_asrc_runtime_resume(struct device *dev) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > sound/soc/tegra/tegra186_asrc.c:80:12: error: ‘tegra186_asrc_runtime_suspend’ defined but not used [-Werror=unused-function] > static int tegra186_asrc_runtime_suspend(struct device *dev) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: tegra186_asrc: mark runtime-pm functions as __maybe_unused commit: dc7680ca7ac6c32b8c18aff36bca728a2f83e2a0 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/tegra/tegra186_asrc.c b/sound/soc/tegra/tegra186_asrc.c index 3c1e20cbb319..9f12faaa609d 100644 --- a/sound/soc/tegra/tegra186_asrc.c +++ b/sound/soc/tegra/tegra186_asrc.c @@ -77,7 +77,7 @@ static void tegra186_asrc_lock_stream(struct tegra186_asrc *asrc, 1); } -static int tegra186_asrc_runtime_suspend(struct device *dev) +static int __maybe_unused tegra186_asrc_runtime_suspend(struct device *dev) { struct tegra186_asrc *asrc = dev_get_drvdata(dev); @@ -87,7 +87,7 @@ static int tegra186_asrc_runtime_suspend(struct device *dev) return 0; } -static int tegra186_asrc_runtime_resume(struct device *dev) +static int __maybe_unused tegra186_asrc_runtime_resume(struct device *dev) { struct tegra186_asrc *asrc = dev_get_drvdata(dev); int id;
sound/soc/tegra/tegra186_asrc.c:90:12: error: ‘tegra186_asrc_runtime_resume’ defined but not used [-Werror=unused-function] static int tegra186_asrc_runtime_resume(struct device *dev) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ sound/soc/tegra/tegra186_asrc.c:80:12: error: ‘tegra186_asrc_runtime_suspend’ defined but not used [-Werror=unused-function] static int tegra186_asrc_runtime_suspend(struct device *dev) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Mark these functions as __maybe_unused to avoid this kind of warning. Fixes: a2df8c2d5b36 ("ASoC: tegra: Add Tegra186 based ASRC driver") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- sound/soc/tegra/tegra186_asrc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)