| Message ID | 20220427112528.4097815-5-andre.przywara@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | None | expand |
On Wed, Apr 27, 2022 at 12:25:21PM +0100, Andre Przywara wrote: > The Arm PrimeCell Advanced Audio CODEC Interface (AACI aka PL041) is > a peripheral that provides communication with an audio CODEC. I've got this one individual patch. What's the story with depenedencies and cross tree work?
On Wed, Apr 27, 2022 at 12:25:21PM +0100, Andre Przywara wrote: > The Arm PrimeCell Advanced Audio CODEC Interface (AACI aka PL041) is > a peripheral that provides communication with an audio CODEC. This is a standalone sound device, you should submit this to the main ALSA maintainers.
On Wed, 27 Apr 2022 12:41:37 +0100 Mark Brown <broonie@kernel.org> wrote: Hi Mark, > On Wed, Apr 27, 2022 at 12:25:21PM +0100, Andre Przywara wrote: > > The Arm PrimeCell Advanced Audio CODEC Interface (AACI aka PL041) is > > a peripheral that provides communication with an audio CODEC. > > I've got this one individual patch. What's the story with depenedencies > and cross tree work? Sorry, I didn't want to bother you with all the other totally unrelated DT bindings conversions, as this is the only sound related binding, and it's self-contained. Also it's just a *binding* *conversion*, so probably only mildly interesting from a kernel and code perspective. I was assuming that Rob usually takes those binding patches, or do they go through the affected subsystem tree? As mentioned, this patch stands on its own, and there are no dependencies, so it should be fine either way. Anyway, this is the whole series, if you are interested: https://lore.kernel.org/linux-arm-kernel/20220427112528.4097815-1-andre.przywara@arm.com/ Cheers, Andre
On Wed, Apr 27, 2022 at 02:33:45PM +0100, Andre Przywara wrote: > I was assuming that Rob usually takes those binding patches, or do they go > through the affected subsystem tree? Bindings usually go through the subsystem.
On Wed, 27 Apr 2022 14:32:04 +0100 Mark Brown <broonie@kernel.org> wrote: > On Wed, Apr 27, 2022 at 12:25:21PM +0100, Andre Przywara wrote: > > > The Arm PrimeCell Advanced Audio CODEC Interface (AACI aka PL041) is > > a peripheral that provides communication with an audio CODEC. > > This is a standalone sound device, you should submit this to the main > ALSA maintainers. You mean Jaroslav and Takashi? get_maintainers.pl just returned yours and Liam's name, plus alsa-devel, because sound/arm/aaci.c is not touched. But I can of course forward the patch to them. Cheers, Andre
On Wed, Apr 27, 2022 at 02:52:34PM +0100, Andre Przywara wrote: > Mark Brown <broonie@kernel.org> wrote: > > This is a standalone sound device, you should submit this to the main > > ALSA maintainers. > You mean Jaroslav and Takashi? get_maintainers.pl just returned yours and > Liam's name, plus alsa-devel, because sound/arm/aaci.c is not touched. You shouldn't just blindly trust the output of get_maintainers - it's got a tendency to both false positives and false negatives. When adding a binding for a device you should pretty much always be including the maintainers for the relevant driver if there is one.
On 27/04/2022 13:25, Andre Przywara wrote: > The Arm PrimeCell Advanced Audio CODEC Interface (AACI aka PL041) is > a peripheral that provides communication with an audio CODEC. > > Add a simple DT schema binding for it, so that DTs can be validated > automatically. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- > .../devicetree/bindings/sound/amba-pl041.yaml | 62 +++++++++++++++++++ > 1 file changed, 62 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/amba-pl041.yaml > > diff --git a/Documentation/devicetree/bindings/sound/amba-pl041.yaml b/Documentation/devicetree/bindings/sound/amba-pl041.yaml > new file mode 100644 > index 0000000000000..f00796d5ea473 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/amba-pl041.yaml Filename: vendor,device, so "arm,amba-pl041" or "arm,pl041" > @@ -0,0 +1,62 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/amba-pl041.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Arm Ltd. PrimeCell PL041 AACI sound interface > + > +maintainers: > + - Andre Przywara <andre.przywara@arm.com> > + > +description: > + The Arm PrimeCell Advanced Audio CODEC Interface (AACI) is an AMBA compliant > + peripheral that provides communication with an audio CODEC using the AC-link > + protocol. > + > +# We need a select here so we don't match all nodes with 'arm,primecell' > +select: > + properties: > + compatible: > + contains: > + const: arm,pl041 > + required: > + - compatible > + > +properties: > + compatible: > + items: > + - const: arm,pl041 > + - const: arm,primecell > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + description: APB register access clock > + > + clock-names: > + const: apb_pclk > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + > +additionalProperties: false > + > +examples: > + - | > + aaci@40000 { Would be nice to find here a generic node name, so "audio-controller"? It's not a codec, right? > + compatible = "arm,pl041", "arm,primecell"; > + reg = <0x040000 0x1000>; > + interrupts = <11>; > + clocks = <&v2m_clk24mhz>; > + clock-names = "apb_pclk"; > + }; > + > +... Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/amba-pl041.yaml b/Documentation/devicetree/bindings/sound/amba-pl041.yaml new file mode 100644 index 0000000000000..f00796d5ea473 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/amba-pl041.yaml @@ -0,0 +1,62 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/amba-pl041.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Arm Ltd. PrimeCell PL041 AACI sound interface + +maintainers: + - Andre Przywara <andre.przywara@arm.com> + +description: + The Arm PrimeCell Advanced Audio CODEC Interface (AACI) is an AMBA compliant + peripheral that provides communication with an audio CODEC using the AC-link + protocol. + +# We need a select here so we don't match all nodes with 'arm,primecell' +select: + properties: + compatible: + contains: + const: arm,pl041 + required: + - compatible + +properties: + compatible: + items: + - const: arm,pl041 + - const: arm,primecell + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + description: APB register access clock + + clock-names: + const: apb_pclk + +required: + - compatible + - reg + - interrupts + - clocks + +additionalProperties: false + +examples: + - | + aaci@40000 { + compatible = "arm,pl041", "arm,primecell"; + reg = <0x040000 0x1000>; + interrupts = <11>; + clocks = <&v2m_clk24mhz>; + clock-names = "apb_pclk"; + }; + +...
The Arm PrimeCell Advanced Audio CODEC Interface (AACI aka PL041) is a peripheral that provides communication with an audio CODEC. Add a simple DT schema binding for it, so that DTs can be validated automatically. Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- .../devicetree/bindings/sound/amba-pl041.yaml | 62 +++++++++++++++++++ 1 file changed, 62 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/amba-pl041.yaml