From patchwork Wed May 4 17:08:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Charles Keepax X-Patchwork-Id: 12838209 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DEA8CC433EF for ; Wed, 4 May 2022 17:11:09 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1141B167D; Wed, 4 May 2022 19:10:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1141B167D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1651684268; bh=tzvg8pGP6KVeNqdtTJHUPfeXSUE6GKf+40/svP3ys5A=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=J1BtF3DHiaLSok5JxK5ycgaLTrz2ZYYbjcnn5isDdfnZme3YVvQKZeJFHLWSrpAR7 YslOTWzSgFEELF1YjCaRpnIQGKuIeVlH8xPdYHt7KWFua5ZMUTYWRZOcfFAbbFbLXp dq7E3Ikb9ARQlGM8iVi+vJDKhjND/KEbzaj6dqfk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4DB55F80533; Wed, 4 May 2022 19:09:26 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id AF84CF800D3; Wed, 4 May 2022 19:09:22 +0200 (CEST) Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 36FC2F800D3 for ; Wed, 4 May 2022 19:09:12 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 36FC2F800D3 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="FWKhKdqw" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2446CVq4001835; Wed, 4 May 2022 12:09:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=PODMain02222019; bh=EI90RMcyBIAi4FClwD/aIfZyhedVb/sh3OETIn8Up8w=; b=FWKhKdqwQmaHr1od8bZHvQv0X26JEVVSXN+3qltM3MbLE0Q7+aVOI5DEs6phZER8N5M6 1UdYBmVZQssJ0vjKHu1h3fgjw5Q7Ji7WMLcBZrxkiAkvF89oKpLwD/ZxeIjSk6UY4jL+ lYGdbv8vGd+04jfFn1De5+9yv9ndKJO7jJg0bew1dhUz464UoX8d/BxY8/3UG3DKxCgg OODTEmb3gVRJLOCtiljMBFxVEiA/0TDTbk0ROU6R/TwmSmuxISl3Zg2kq7lJ0VQHaC6V cERkusEFLuizU5vFmlKOSs6FCF1tOA1n2Re0yv1DSGceHLo57i9O23xp75lp+L5vZlKA Ew== Received: from ediex02.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 3fs2h2d8fp-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Wed, 04 May 2022 12:09:08 -0500 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 4 May 2022 18:09:05 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.2375.24 via Frontend Transport; Wed, 4 May 2022 18:09:05 +0100 Received: from algalon.ad.cirrus.com (algalon.ad.cirrus.com [198.90.251.122]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 493E511D3; Wed, 4 May 2022 17:09:05 +0000 (UTC) From: Charles Keepax To: Subject: [PATCH 02/38] ASoC: atmel-pdmic: Remove endianness flag on pdmic component Date: Wed, 4 May 2022 18:08:29 +0100 Message-ID: <20220504170905.332415-3-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220504170905.332415-1-ckeepax@opensource.cirrus.com> References: <20220504170905.332415-1-ckeepax@opensource.cirrus.com> MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: Dl2PnAZgHnN7DisnkOvXW_Y4Hvvsj-yz X-Proofpoint-GUID: Dl2PnAZgHnN7DisnkOvXW_Y4Hvvsj-yz X-Proofpoint-Spam-Reason: safe Cc: oder_chiou@realtek.com, steven.eckhoff.opensource@gmail.com, alexandre.belloni@bootlin.com, lars@metafoo.de, kuninori.morimoto.gx@renesas.com, kmarinushkin@birdec.com, patches@opensource.cirrus.com, linux-mediatek@lists.infradead.org, lgirdwood@gmail.com, jiaxin.yu@mediatek.com, tzungbi@google.com, srinivas.kandagatla@linaro.org, matthias.bgg@gmail.com, chrome-platform@lists.linux.dev, codrin.ciubotariu@microchip.com, alsa-devel@alsa-project.org, bleung@chromium.org, cychiang@chromium.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" The endianness flag should have been removed when the driver was ported across from having both a CODEC and CPU side component, to just having a CPU component and using the dummy for the CODEC. The endianness flag is used to indicate that the device is completely ambivalent to the endianness of the data, typically due to the endianness being lost over the hardware link (ie. the link defines bit ordering). It's usage didn't have any effect when the driver had both a CPU and CODEC component, since the union of those equals the CPU side settings, but now causes the driver to falsely report it supports big endian. Correct this by removing the flag. Fixes: f3c668074a04 ("ASoC: atmel-pdmic: remove codec component") Signed-off-by: Charles Keepax --- sound/soc/atmel/atmel-pdmic.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/atmel/atmel-pdmic.c b/sound/soc/atmel/atmel-pdmic.c index 42117de299e74..ea34efac2fff5 100644 --- a/sound/soc/atmel/atmel-pdmic.c +++ b/sound/soc/atmel/atmel-pdmic.c @@ -481,7 +481,6 @@ static const struct snd_soc_component_driver atmel_pdmic_cpu_dai_component = { .num_controls = ARRAY_SIZE(atmel_pdmic_snd_controls), .idle_bias_on = 1, .use_pmdown_time = 1, - .endianness = 1, }; /* ASoC sound card */